Drop metadata annotations in favor of linked data - #123
Conversation
Signed-off-by: Juan Cruz Viotti <[email protected]>
🤖 Augment PR SummarySummary: This PR removes a large set of custom metadata annotations from generated schemas and templates, favoring linked-data identifiers instead. Changes:
Technical Notes: The generated schema validation constraints remain largely equivalent (e.g., 🤖 Was this summary useful? React with 👍 or 👎 |
| @@ -17,7 +17,15 @@ | |||
| ), | |||
| "x-license": "https://github.com/sourcemeta/std/blob/main/LICENSE", | |||
| "x-links": ["https://www.iso.org/iso-4217-currency-codes.html"], | |||
| "anyOf": ( | |||
| "if": { | |||
There was a problem hiding this comment.
x-jsonld-self is now nested under then, so any tooling that extracts linked-data identifiers by scanning only the root schema object may stop seeing identifiers for most values; consider verifying the linked-data extraction path evaluates/visits conditional subschemas.
Severity: medium
Other Locations
templates/schemas/iso/currency/2015/historical/alpha-currency.jq:20templates/schemas/iso/language/2023/set-2-bibliographic.jq:9templates/schemas/iso/language/2023/set-2-terminologic.jq:9
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
No issues found across 835 files
Not reviewed (too large): schemas/iso/language/2023/set-3.json (~56,516 lines), schemas/iso/language/2023/set-2-bibliographic.json (~4,440 lines), schemas/iso/language/2023/set-2-terminologic.json (~4,440 lines), schemas/bipm/si/2019/derived/symbol.json (~2,752 lines), schemas/iso/country/2020/alpha-3.json (~2,239 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.
Note: This PR contains a large number of files. cubic only reviews up to 200 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
Re-trigger cubic
Signed-off-by: Juan Cruz Viotti <[email protected]>
Signed-off-by: Juan Cruz Viotti [email protected]