Skip to content

Drop metadata annotations in favor of linked data - #123

Merged
jviotti merged 2 commits into
mainfrom
less-annotations
Aug 3, 2026
Merged

Drop metadata annotations in favor of linked data#123
jviotti merged 2 commits into
mainfrom
less-annotations

Conversation

@jviotti

@jviotti jviotti commented Aug 3, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti [email protected]

Review in cubic

@augmentcode

augmentcode Bot commented Aug 3, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR removes a large set of custom metadata annotations from generated schemas and templates, favoring linked-data identifiers instead.

Changes:

  • Drops the std/symbol lint rule and deletes rules/symbol.json.
  • Removes x-symbol, x-prefix-factor, and x-status annotations across many existing schema files (notably SI prefixed units and XBRL UTR unit enums).
  • Simplifies several JQ schema templates by switching from anyOf-of-const objects to plain enum lists.
  • Introduces conditional x-jsonld-self emission in currency/language templates so values without minted authority IRIs (e.g. XAD, ISO 639 local-use codes) don’t get identifiers.
  • Adds/normalizes top-level linked-data placeholders (.../{this}) where per-value annotations were previously emitted.

Technical Notes: The generated schema validation constraints remain largely equivalent (e.g., anyOf of constenum), while value-level descriptive metadata is intentionally reduced.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@@ -17,7 +17,15 @@
),
"x-license": "https://github.com/sourcemeta/std/blob/main/LICENSE",
"x-links": ["https://www.iso.org/iso-4217-currency-codes.html"],
"anyOf": (
"if": {

@augmentcode augmentcode Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-jsonld-self is now nested under then, so any tooling that extracts linked-data identifiers by scanning only the root schema object may stop seeing identifiers for most values; consider verifying the linked-data extraction path evaluates/visits conditional subschemas.

Severity: medium

Other Locations
  • templates/schemas/iso/currency/2015/historical/alpha-currency.jq:20
  • templates/schemas/iso/language/2023/set-2-bibliographic.jq:9
  • templates/schemas/iso/language/2023/set-2-terminologic.jq:9

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 835 files

Not reviewed (too large): schemas/iso/language/2023/set-3.json (~56,516 lines), schemas/iso/language/2023/set-2-bibliographic.json (~4,440 lines), schemas/iso/language/2023/set-2-terminologic.json (~4,440 lines), schemas/bipm/si/2019/derived/symbol.json (~2,752 lines), schemas/iso/country/2020/alpha-3.json (~2,239 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.

Note: This PR contains a large number of files. cubic only reviews up to 200 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.

Re-trigger cubic

Signed-off-by: Juan Cruz Viotti <[email protected]>
@jviotti
jviotti merged commit 7dfea5f into main Aug 3, 2026
3 checks passed
@jviotti
jviotti deleted the less-annotations branch August 3, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant