Skip to content

ci: bind intermediate-docker workflow inputs via env before shell - #1815

Open
SashaMIT wants to merge 1 commit into
scroll-tech:developfrom
SashaMIT:ci/bind-intermediate-docker-inputs-env
Open

ci: bind intermediate-docker workflow inputs via env before shell#1815
SashaMIT wants to merge 1 commit into
scroll-tech:developfrom
SashaMIT:ci/bind-intermediate-docker-inputs-env

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • Bind github.event.inputs.BASE_IMAGE and related version inputs through env: before the set tag env shell step.
  • Same class as GitHub’s documented script-injection guidance for interpolating workflow inputs into run: scripts.

Test plan

  • Intermediate docker workflow still builds the correct TAG for each BASE_IMAGE choice
  • Docker build-push step still receives the expected Dockerfile / tags via existing expressions

Summary by CodeRabbit

  • Chores
    • Improved Docker workflow tag generation by reliably handling workflow inputs.
    • Existing tag formats and fallback behavior remain unchanged.

Pass BASE_IMAGE and version inputs through env: before TAG construction
(script-injection class for workflow_dispatch inputs).
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 55fb2ad2-5338-4fb1-8d43-53cc0937d929

📥 Commits

Reviewing files that changed from the base of the PR and between 788fdf0 and 5762a0f.

📒 Files selected for processing (1)
  • .github/workflows/intermediate-docker.yml

📝 Walkthrough

Walkthrough

The Docker workflow now assigns workflow inputs to environment variables before selecting the base image and building the Docker tag. Existing tag formats and fallback behavior remain unchanged.

Changes

Docker tag generation

Layer / File(s) Summary
Workflow tag generation
.github/workflows/intermediate-docker.yml
The tag-generation step exposes workflow inputs through environment variables. Shell variables now drive image-selection comparisons and tag construction.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the CI change to bind workflow inputs through environment variables before shell evaluation.
Description check ✅ Passed The description explains what and why the workflow changes, describes the approach, and includes a relevant test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant