Skip to content

Allow fork PR checkout - #2360

Open
SimonYansenZhao wants to merge 1 commit into
stagingfrom
simonz/checkout7
Open

Allow fork PR checkout#2360
SimonYansenZhao wants to merge 1 commit into
stagingfrom
simonz/checkout7

Conversation

@SimonYansenZhao

Copy link
Copy Markdown
Collaborator

Description

NOTE: The changes in this PR must be merged into the main branch to take effect!

This PR resolves the problem causing tests in #2359 fail (see https://github.com/recommenders-team/recommenders/actions/runs/30350844369/job/90247703106?pr=2359). In addition, this PR upgrades the versions for actions in the workflows as well.

According to actions/checkout, PRs from fork repos will not be checked out by default anymore if workflows are triggered by pull_request_target. Since #2334, workflows from fork PRs are triggered by pull_request_target, which causes tests in #2359 fail.

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

Signed-off-by: Simon Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant