[3.15] gh-152548: Add options, env and timeout parameters to runInSubprocess() (GH-155163) - #155238
Open
serhiy-storchaka wants to merge 2 commits into
Open
[3.15] gh-152548: Add options, env and timeout parameters to runInSubprocess() (GH-155163)#155238serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
… the test (pythonGH-155162) The subprocess writes the result of the test before exiting, so a crash during interpreter finalization left the result intact and the test was reported as passed. Check the exit code too, after replaying the outcomes, so that a failure of the test itself is still reported as a failure. (cherry picked from commit ef0affb) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
…rocess() (pythonGH-155163) They run the test subprocess with specific interpreter command line options and environment variables, and limit how long it may take. All are keyword-only. env is layered over the inherited environment; a None value unsets a variable. There is no timeout by default. (cherry picked from commit 1d90627) Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
This was referenced Aug 5, 2026
Documentation build overview
291 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of GH-155163; miss-islington could not apply it cleanly because
GH-155167 (the backport of GH-155162) has not landed on 3.15 yet. This branch is
based on GH-155167 and should be merged after it.
Add three keyword-only parameters to
runInSubprocess():options-- interpreter command line options for the subprocess.env-- environment variables, on top of the inherited environment; a valueof
Noneunsets a variable.timeout-- how long to wait for the subprocess; the test is reported as anerror if it does not complete in time. There is no timeout by default.
(cherry picked from commit 1d90627)