[3.14] gh-64502: Fix Argument Clinic support of optional groups with defaults (GH-155191) - #155216
Merged
serhiy-storchaka merged 2 commits intoAug 5, 2026
Merged
Conversation
…efaults (pythonGH-155191) Parameters with a default value which are not in any group were always required in the generated argument parsing code, although they were rendered as optional in the signature. They can now be omitted, and ambiguous combinations of optional groups and parameters with a default value are rejected. (cherry picked from commit caac927) Co-authored-by: Serhiy Storchaka <[email protected]> Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
serhiy-storchaka
requested review from
ericsnowcurrently and
erlend-aasland
as code owners
August 5, 2026 07:35
This was referenced Aug 5, 2026
serhiy-storchaka
enabled auto-merge (squash)
August 5, 2026 11:39
…c header The added test functions made Modules/clinic/_testclinic.c.h exceed the limit. The main and 3.15 branches already use the larger value. Co-authored-by: Serhiy Storchaka <[email protected]> Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters with a default value which are not in any group were always
required in the generated argument parsing code, although they were
rendered as optional in the signature. They can now be omitted, and
ambiguous combinations of optional groups and parameters with a default
value are rejected.
(cherry picked from commit caac927)
Co-authored-by: Serhiy Storchaka [email protected]
Co-Authored-By: Claude Opus 5 (1M context) [email protected]