Skip to content

test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960

Open
panva wants to merge 2 commits into
nodejs:mainfrom
panva:actions-fips
Open

test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom
panva:actions-fips

Conversation

@panva

@panva panva commented Aug 2, 2026

Copy link
Copy Markdown
Member

This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).

Closes: #48379

@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Aug 2, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@panva
panva requested a review from aduh95 August 2, 2026 14:31
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 2, 2026
@panva panva added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Aug 2, 2026
Comment thread tools/dep_updaters/update-nixpkgs-pin.sh Outdated
@github-actions

This comment was marked as outdated.

2 similar comments
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64960   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files         759      759           
  Lines      247634   247635    +1     
  Branches    46687    46680    -7     
=======================================
+ Hits       223623   223635   +12     
- Misses      15462    15465    +3     
+ Partials     8549     8535   -14     
Files with missing lines Coverage Δ
lib/internal/crypto/webcrypto.js 97.81% <100.00%> (+<0.01%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva
panva force-pushed the actions-fips branch 2 times, most recently from 68ba143 to 5699e8d Compare August 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Comment thread tools/dep_updaters/update-nixpkgs-pin.sh Outdated
Comment thread tools/nix/openssl-fips.nix Outdated
Comment thread tools/nix/openssl-fips.nix Outdated

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@panva

panva commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

LGTM if CI is green

Thank you for your help

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 455 -> 459 => +4 4 / 459 = 0.8%
aarch64-linux 456 -> 460 => +4 4 / 460 = 0.8%
x86_64-darwin 393 -> 396 => +3 3 / 396 = 0.7%
aarch64-darwin 398 -> 401 => +3 3 / 401 = 0.7%
Total 1702 -> 1716 => +14 14 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@
+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)
+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)
+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)
+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)
+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)
+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)
+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)
+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)
+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)
+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)
+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)
+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)
+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)
+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)

@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 4, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled

4 participants