src: update repeated use strings to env - #64760
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/minor-string-uses
branch
from
July 26, 2026 15:18
6ee7f78 to
0179359
Compare
anonrig
approved these changes
Jul 26, 2026
jasnell
force-pushed
the
jasnell/minor-string-uses
branch
from
July 27, 2026 13:56
0179359 to
8f79ab7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: James M Snell <[email protected]>
jasnell
force-pushed
the
jasnell/minor-string-uses
branch
from
August 4, 2026 13:38
8f79ab7 to
7090b96
Compare
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
Aug 4, 2026
jasnell
added
the
author ready
Collaborator
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #64760 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 759 759
Lines 247621 247609 -12
Branches 46672 46682 +10
=======================================
+ Hits 223603 223605 +2
+ Misses 15473 15471 -2
+ Partials 8545 8533 -12
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 41afbd3 |
leah-1ee
added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
Follow-up to nodejs#59891, covering files it missed. Overlapping locations (node_ffi.cc, crypto_util.cc) were already handled by nodejs#64760. Refs: nodejs#59891 Refs: nodejs#64760 Refs: nodejs#64912 Signed-off-by: leah-1ee <[email protected]>
leah-1ee
added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
Follow-up to nodejs#59891, covering files it missed. Overlapping locations (node_ffi.cc, crypto_util.cc) were already handled by nodejs#64760. Refs: nodejs#59891 Refs: nodejs#64760 Refs: nodejs#64912 Signed-off-by: leah-1ee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move strings that are repeated multiple times to env properties