lib Fix Part 6/6 – Array.isArray by graphemecluster · Pull Request #50454 · microsoft/TypeScript

graphemecluster (graphemecluster) · 2022-08-25T18:24:49Z

General Information

PR separated out from #49855, because there might be some members expecting smaller PRs. As mentioned in the comments from the big PR, whether to review a single, large PR or 6 smaller PRs is up to the TypeScript Team to decide. I couldn't have found a better way for this; hopefully this will not bring any trouble to the Team.

This PR partially fixes #49773.
For details and the track list about the changes, please see #49773.

Part 6/6, Array.isArray

Fix #17002
Actually fix #32497
Fix #33700
Fix #41808
Actually fix #43247

This PR supersedes #48228 as it fails to address readonly number[].
~~I am confident to this solution.~~
Edit: I guess I must retract this. See the results below. 😔

Nathan Shively-Sanders (sandersn) · 2022-09-13T23:22:24Z

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) · 2022-09-13T23:22:27Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based top-repos suite on this PR at f660c25. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-09-13T23:22:27Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at f660c25. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-09-13T23:22:29Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based user code test suite on this PR at f660c25. You can monitor the build here.

Update: The results are in!

Nathan Shively-Sanders (sandersn) · 2022-09-13T23:25:04Z

We tried this a couple of years ago; I don't remember what problems it ran into but I don't think #48228 was the only attempt.

TypeScript Bot (typescript-bot) · 2022-09-13T23:35:55Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the user test suite comparing main and refs/pull/50454/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.json

[NEW] error TS2339: Property 'length' does not exist on type 'T[P] extends any ? Extract<true extends false & T[P] ? any[] : T[P] extends readonly any[] ? T[P] : T[P] extends string ? never : T[P] extends ArrayLike<...> | Iterable<...> ? U[] : unknown[], T[P]> : never'.
- lib/config/defaults.js#L96
[NEW] error TS2339: Property 'slice' does not exist on type 'T[P] extends any ? Extract<true extends false & T[P] ? any[] : T[P] extends readonly any[] ? T[P] : T[P] extends string ? never : T[P] extends ArrayLike<...> | Iterable<...> ? U[] : unknown[], T[P]> : never'.
- lib/config/defaults.js#L100

tsconfig.types.json

[NEW] error TS7053: Element implicitly has an 'any' type because expression of type 'number' can't be used to index type '(T[P] & null extends any ? Extract<T[P] & null extends readonly any[] ? T[P] & null : T[P] & null extends string ? never : T[P] & null extends ArrayLike<...> | Iterable<...> ? U[] : unknown[], T[P] & null> : never) | (T[P] & {} extends any ? Extract<...> : never)'.
- lib/config/defaults.js#L97
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Object'.
- lib/stats/StatsPrinter.js#L204
[MISSING] error TS2345: Argument of type '{ _index: number; type: string; constructor?: Function | undefined; toString?: (() => string) | undefined; toLocaleString?: (() => string) | undefined; valueOf?: (() => Object) | undefined; hasOwnProperty?: ((v: PropertyKey) => boolean) | undefined; isPrototypeOf?: ((v: Object) => boolean) | undefined; propertyIsEnu...' is not assignable to parameter of type 'Object'.
- lib/stats/StatsPrinter.js#L205

TypeScript Bot (typescript-bot) · 2022-09-14T01:10:38Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the top-repos suite comparing main and refs/pull/50454/merge:

Something interesting changed - please have a look.

Details

cheeriojs/cheerio

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2322: Type 'ChildNode[] | (S extends any ? Extract<true extends false & S ? any[] : S extends readonly any[] ? S : S extends string ? never : S extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], S> : never) | T[] | (NonNullable<...> extends any ? Extract<...> : never) | undefined' is not assignable to type 'AnyNode[] | undefined'.
- src/load.ts#L165

conwnet/github1s

2 of 4 projects failed to build with the old tsc and were ignored

extensions/github1s/tsconfig.json

error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not assignable to type 'T[]'.
- extensions/github1s/src/providers/text-search.ts#L12

excalidraw/excalidraw

3 of 5 projects failed to build with the old tsc and were ignored

tsconfig-types.json

error TS2322: Type 'readonly (readonly [number, number])[] | number[][]' is not assignable to type 'readonly (readonly [number, number])[]'.
- src/data/restore.ts#L202

graphql/graphql-js

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2339: Property 'map' does not exist on type 'never'.
- src/testUtils/expectJSON.ts#L20
error TS2345: Argument of type 'readonly ASTNode[] | undefined' is not assignable to parameter of type 'ASTNode[] | undefined'.
- src/error/GraphQLError.ts#L103

JedWatson/react-select

3 of 5 projects failed to build with the old tsc and were ignored

packages/react-select/src/tests/tsconfig.json

error TS7053: Element implicitly has an 'any' type because expression of type 'number' can't be used to index type '(OnChangeValue<Option, IsMulti> extends any ? Extract<true extends false & OnChangeValue<Option, IsMulti> ? any[] : OnChangeValue<...> extends readonly any[] ? OnChangeValue<...> : OnChangeValue<...> extends string ? never : OnChangeValue<...> extends ArrayLike<...> | Iterable<...> ? U[] : unknown[], OnChangeValue<....'.
- packages/react-select/src/useCreatable.ts#L181
error TS2339: Property 'length' does not exist on type '(OnChangeValue<Option, IsMulti> extends any ? Extract<true extends false & OnChangeValue<Option, IsMulti> ? any[] : OnChangeValue<...> extends readonly any[] ? OnChangeValue<...> : OnChangeValue<...> extends string ? never : OnChangeValue<...> extends ArrayLike<...> | Iterable<...> ? U[] : unknown[], OnChangeValue<....'.
- packages/react-select/src/useCreatable.ts#L181

microsoft/playwright

4 of 10 projects failed to build with the old tsc and were ignored

packages/html-reporter/tsconfig.json

error TS2322: Type 'string | string[] | ({ name?: NameOrSegments | undefined; } & T extends any ? Extract<true extends false & { name?: NameOrSegments | undefined; } & T ? any[] : { ...; } & T extends readonly any[] ? { ...; } & T : { ...; } & T extends string ? never : { ...; } & T extends ArrayLike<...> | Iterable<...> ? U[] : unknow...' is not assignable to type 'NameOrSegments | undefined'.
- packages/playwright-test/src/matchers/toMatchSnapshot.ts#L70

microsoft/vscode

3 of 54 projects failed to build with the old tsc and were ignored

extensions/ipynb/tsconfig.json

error TS2345: Argument of type 'unknown[]' is not assignable to parameter of type 'string | string[]'.
- extensions/ipynb/src/deserializers.ts#L129
- extensions/ipynb/src/deserializers.ts#L144

extensions/markdown-language-features/tsconfig.browser.json

error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- extensions/markdown-language-features/src/markdownExtensions.ts#L18

extensions/markdown-language-features/tsconfig.json

error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- extensions/markdown-language-features/src/markdownExtensions.ts#L18

extensions/vscode-colorize-tests/tsconfig.json

error TS2571: Object is of type 'unknown'.
- extensions/vscode-colorize-tests/src/colorizer.test.ts#L31
- extensions/vscode-colorize-tests/src/colorizer.test.ts#L31

src/tsconfig.json

error TS2322: Type 'any[] | unknown[]' is not assignable to type '(HTMLElement | Record<string, HTMLElement>)[] | undefined'.
- src/vs/base/browser/dom.ts#L1756
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L630
error TS2571: Object is of type 'unknown'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L630
error TS2322: Type '{ data: { label: unknown; score: FuzzyScore; }; visibility: TreeVisibility.Visible | TreeVisibility.Recurse; }' is not assignable to type 'TreeFilterResult<FuzzyScore | LabelFuzzyScore>'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L633
error TS2339: Property 'map' does not exist on type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)'.
- src/vs/base/common/arrays.ts#L580
error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not assignable to type 'T[]'.
- src/vs/base/common/arrays.ts#L587
error TS2488: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/vs/workbench/api/common/extHostTreeViews.ts#L353
error TS2339: Property 'join' does not exist on type 'never'.
- src/vs/workbench/contrib/notebook/common/services/notebookSimpleWorker.ts#L172
- src/vs/workbench/contrib/snippets/browser/snippetsFile.ts#L278
error TS2322: Type 'unknown[]' is not assignable to type 'ITerminalInstance[]'.
- src/vs/workbench/contrib/terminal/browser/terminalTabsList.ts#L587
error TS2769: No overload matches this call.
- src/vs/workbench/services/environment/browser/environmentService.ts#L227
error TS2322: Type 'unknown[]' is not assignable to type 'string[]'.
- src/vs/workbench/services/extensions/browser/extensionUrlHandler.ts#L375
- src/vs/workbench/services/textMate/browser/abstractTextMateService.ts#L144

src/tsconfig.monaco.json

error TS2322: Type 'any[] | unknown[]' is not assignable to type '(HTMLElement | Record<string, HTMLElement>)[] | undefined'.
- src/vs/base/browser/dom.ts#L1756
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L630
error TS2571: Object is of type 'unknown'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L630
error TS2322: Type '{ data: { label: unknown; score: FuzzyScore; }; visibility: TreeVisibility.Visible | TreeVisibility.Recurse; }' is not assignable to type 'TreeFilterResult<FuzzyScore | LabelFuzzyScore>'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L633
error TS2339: Property 'map' does not exist on type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)'.
- src/vs/base/common/arrays.ts#L580
error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not assignable to type 'T[]'.
- src/vs/base/common/arrays.ts#L587

src/tsconfig.tsec.json

error TS2322: Type 'any[] | unknown[]' is not assignable to type '(HTMLElement | Record<string, HTMLElement>)[] | undefined'.
- src/vs/base/browser/dom.ts#L1756
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L630
error TS2571: Object is of type 'unknown'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L630
error TS2322: Type '{ data: { label: unknown; score: FuzzyScore; }; visibility: TreeVisibility.Visible | TreeVisibility.Recurse; }' is not assignable to type 'TreeFilterResult<FuzzyScore | LabelFuzzyScore>'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L633
error TS2339: Property 'map' does not exist on type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)'.
- src/vs/base/common/arrays.ts#L580
error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not assignable to type 'T[]'.
- src/vs/base/common/arrays.ts#L587
error TS2488: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/vs/workbench/api/common/extHostTreeViews.ts#L353
error TS2339: Property 'join' does not exist on type 'never'.
- src/vs/workbench/contrib/notebook/common/services/notebookSimpleWorker.ts#L172
- src/vs/workbench/contrib/snippets/browser/snippetsFile.ts#L278
error TS2322: Type 'unknown[]' is not assignable to type 'ITerminalInstance[]'.
- src/vs/workbench/contrib/terminal/browser/terminalTabsList.ts#L587
error TS2769: No overload matches this call.
- src/vs/workbench/services/environment/browser/environmentService.ts#L227
error TS2322: Type 'unknown[]' is not assignable to type 'string[]'.
- src/vs/workbench/services/extensions/browser/extensionUrlHandler.ts#L375
- src/vs/workbench/services/textMate/browser/abstractTextMateService.ts#L144

mobxjs/mobx

7 of 9 projects failed to build with the old tsc and were ignored

packages/mobx/tsconfig.json

error TS2322: Type 'this' is not assignable to type 'void'.
- packages/mobx/src/types/observablemap.ts#L349

neoclide/coc.nvim

tsconfig.json

error TS2339: Property 'length' does not exist on type 'T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never'.
- src/handler/index.ts#L180
error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not assignable to type 'T[]'.
- src/util/array.ts#L4

pnpm/pnpm

119 of 120 projects failed to build with the old tsc and were ignored

packages/pnpm/tsconfig.json

error TS2322: Type 'unknown[]' is not assignable to type 'string[]'.
- packages/pnpm/src/getOptionType.ts#L37

prisma/prisma

57 of 67 projects failed to build with the old tsc and were ignored

packages/engines/tsconfig.build.json

error TS2345: Argument of type 'unknown[] | string[]' is not assignable to parameter of type 'string[]'.
- packages/fetch-engine/src/getLatestTag.ts#L35

react-hook-form/react-hook-form

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2339: Property 'forEach' does not exist on type 'Path<TFieldValues>[] | readonly Path<TFieldValues>[] | (Path<TFieldValues> extends any ? Extract<true extends false & Path<...> ? any[] : Path<...> extends readonly any[] ? Path<...> : Path<...> extends string ? never : Path<...> extends ArrayLike<...> | Iterable<...> ? U[] : unknown[], Path<...>> : never) | (Path<....'.
- src/logic/createFormControl.ts#L840
error TS7006: Parameter 'inputName' implicitly has an 'any' type.
- src/logic/createFormControl.ts#L840
error TS2345: Argument of type 'string | Path<TFieldValues> | Path<TFieldValues>[] | readonly Path<TFieldValues>[]' is not assignable to parameter of type 'string'.
error TS2407: The right-hand side of a 'for...in' statement must be of type 'any', an object type or a type parameter, but here has type '(U & object) | (U extends any ? Extract<true extends false & U ? any[] : U extends readonly any[] ? U : U extends string ? never : U extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], U> : never)'.
- src/logic/getDirtyFields.ts#L12
error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '(U & object) | (U extends any ? Extract<true extends false & U ? any[] : U extends readonly any[] ? U : U extends string ? never : U extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], U> : never)'.
error TS2407: The right-hand side of a 'for...in' statement must be of type 'any', an object type or a type parameter, but here has type '(T & object) | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)'.
- src/logic/getDirtyFields.ts#L36
error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '(T & object) | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)'.
error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'unknown'.
- src/logic/getDirtyFields.ts#L51
- src/logic/getDirtyFields.ts#L56
error TS2339: Property 'startsWith' does not exist on type 'string | string[]'.
- src/logic/shouldSubscribeByName.ts#L16
error TS2345: Argument of type 'string | string[]' is not assignable to parameter of type 'string'.
- src/logic/shouldSubscribeByName.ts#L17
error TS2339: Property 'map' does not exist on type 'Partial<FieldArray<TFieldValues, TFieldArrayName>> | Partial<FieldArray<TFieldValues, TFieldArrayName>>[] | (Partial<...> | Partial<...>[])[] | (Partial<...> & any[]) | (Partial<...> & unknown[])'.
error TS2488: Type 'Partial<FieldArray<TFieldValues, TFieldArrayName>>[] | (Partial<FieldArray<TFieldValues, TFieldArrayName>> extends any ? Extract<...> : never) | (Partial<...> | Partial<...>[])[]' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/useFieldArray.ts#L300
error TS2488: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never) | (T | T[])[]' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/utils/append.ts#L4
- src/utils/prepend.ts#L4
error TS2407: The right-hand side of a 'for...in' statement must be of type 'any', an object type or a type parameter, but here has type '(T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never) | (T & object)'.
- src/utils/cloneObject.ts#L18
error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '(T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never) | (T & object)'.
- src/utils/cloneObject.ts#L19
- src/utils/cloneObject.ts#L23
error TS2339: Property 'map' does not exist on type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)'.
- src/utils/fillEmptyArray.ts#L2
error TS2488: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never) | (T | ... 1 more ... | undefined)[]' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/utils/insert.ts#L16

ReactiveX/rxjs

8 of 13 projects failed to build with the old tsc and were ignored

src/tsconfig.cjs.spec.json

error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never) | (O extends any ? Extract<...> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14
error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8
error TS2548: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not an array type or does not have a '[Symbol.iterator]()' method that returns an iterator.
- src/internal/util/mapOneOrManyArgs.ts#L7

src/tsconfig.esm5.rollup.json

error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never) | (O extends any ? Extract<...> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14
error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8
error TS2548: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not an array type or does not have a '[Symbol.iterator]()' method that returns an iterator.
- src/internal/util/mapOneOrManyArgs.ts#L7

src/tsconfig.types.json

error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never) | (O extends any ? Extract<...> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14 in src/tsconfig.types.json
error TS2488: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/internal/util/mapOneOrManyArgs.ts#L7 in src/tsconfig.types.json
error TS2322: Type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8 in src/tsconfig.types.json

refined-github/refined-github

tsconfig.json

error TS2322: Type 'Item[] | (Item extends any ? Extract<true extends false & Item ? any[] : Item extends readonly any[] ? Item : Item extends string ? never : Item extends ArrayLike<...> | Iterable<...> ? U[] : unknown[], Item> : never)' is not assignable to type 'Item[]'.
- source/features/index.tsx#L161

statelyai/xstate

6 of 20 projects failed to build with the old tsc and were ignored

packages/xstate-inspect/tsconfig.json

error TS2339: Property 'some' does not exist on type 'TransitionsConfigArray<TContext, TEvent> | (TransitionsConfigMap<TContext, TEvent> extends any ? Extract<...> : never)'.
- packages/core/src/StateNode.ts#L400 in packages/core/tsconfig.json
error TS2322: Type 'TransitionsConfigArray<TContext, TEvent> | (TransitionsConfigMap<TContext, TEvent> extends any ? Extract<...> : never)' is not assignable to type '(TransitionConfig<TContext, EventObject> & { event: string; })[]'.
- packages/core/src/StateNode.ts#L2022 in packages/core/tsconfig.json

packages/xstate-test/tsconfig.json

error TS2339: Property 'some' does not exist on type 'TransitionsConfigArray<TContext, TEvent> | (TransitionsConfigMap<TContext, TEvent> extends any ? Extract<...> : never)'.
- packages/core/src/StateNode.ts#L400 in packages/core/tsconfig.json
error TS2322: Type 'TransitionsConfigArray<TContext, TEvent> | (TransitionsConfigMap<TContext, TEvent> extends any ? Extract<...> : never)' is not assignable to type '(TransitionConfig<TContext, EventObject> & { event: string; })[]'.
- packages/core/src/StateNode.ts#L2022 in packages/core/tsconfig.json

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2339: Property 'reduce' does not exist on type 'T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never'.
- app/utils/colors.ts#L29 in app/tsconfig.json

vuejs/vue

7 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2339: Property 'indexOf' does not exist on type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)'.
- src/core/instance/render-helpers/check-keycodes.ts#L6

wenyan-lang/wenyan

tsconfig.json

error TS2339: Property 'map' does not exist on type 'never'.
- src/execute.ts#L18

withfig/autocomplete

tsconfig.json

error TS2339: Property 'at' does not exist on type 'T[] | (T extends any ? Extract<true extends false & T ? any[] : T extends readonly any[] ? T : T extends string ? never : T extends ArrayLike<infer U> | Iterable<...> ? U[] : unknown[], T> : never)'.
- src/clojure.ts#L19

graphemecluster (graphemecluster) · 2022-09-15T09:26:00Z

That's bad; it seems that the checker really hate T extends readonly any[] ? T that line.

graphemecluster (graphemecluster) · 2022-09-15T11:57:47Z

It seems that I can't use the TypeScript bot, Nathan Shively-Sanders (@sandersn) please help me run the test suite again.

Nathan Shively-Sanders (sandersn) · 2022-10-12T22:19:38Z

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2022-10-12T22:19:41Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at 2149ae6. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-10-12T22:19:41Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based top-repos suite on this PR at 2149ae6. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-10-12T22:19:42Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based user code test suite on this PR at 2149ae6. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-10-12T22:19:42Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the abridged perf test suite on this PR at 2149ae6. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-10-12T22:34:43Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the user test suite comparing main and refs/pull/50454/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.json

[NEW] error TS2322: Type '{ fileDependencies: string[] | (RuntimeValueOptions & unknown[]); }' is not assignable to type 'true | string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L44
[NEW] error TS2339: Property 'fileDependencies' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L52
- lib/DefinePlugin.js#L66
- lib/DefinePlugin.js#L67
[NEW] error TS2339: Property 'contextDependencies' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L71
- lib/DefinePlugin.js#L72
[NEW] error TS2339: Property 'missingDependencies' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L76
- lib/DefinePlugin.js#L77
[NEW] error TS2339: Property 'buildDependencies' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L81
- lib/DefinePlugin.js#L82
[NEW] error TS2339: Property 'version' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L102
- lib/DefinePlugin.js#L103
- lib/DefinePlugin.js#L104
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- lib/ExternalModuleFactoryPlugin.js#L97
[NEW] error TS2339: Property 'indexOf' does not exist on type 'unknown'.
- lib/ExternalModuleFactoryPlugin.js#L100
[NEW] error TS2339: Property 'slice' does not exist on type 'unknown'.
- lib/ExternalModuleFactoryPlugin.js#L101
- lib/ExternalModuleFactoryPlugin.js#L103
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Externals'.
- lib/ExternalModuleFactoryPlugin.js#L147
[NEW] error TS2339: Property 'hooks' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L90
- lib/MultiCompiler.js#L100
[NEW] error TS2339: Property 'outputPath' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L117
- lib/MultiCompiler.js#L120
- lib/MultiCompiler.js#L127
[NEW] error TS2339: Property 'inputFileSystem' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L152
- lib/MultiCompiler.js#L563
- lib/MultiCompiler.js#L563
- lib/MultiCompiler.js#L564
[NEW] error TS2339: Property 'outputFileSystem' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L161
[NEW] error TS2339: Property 'watchFileSystem' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L170
[NEW] error TS2339: Property 'intermediateFileSystem' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L179
[NEW] error TS2339: Property 'getInfrastructureLogger' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L184
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Compiler'.
- lib/MultiCompiler.js#L220
[NEW] error TS2339: Property 'name' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L223
[NEW] error TS2322: Type 'unknown' is not assignable to type 'Compiler'.
- lib/MultiCompiler.js#L228
- lib/MultiCompiler.js#L229
[NEW] error TS2322: Type '{ compiler: any; setupResult: any; result: any; state: string; children: any[]; parents: any[]; }[]' is not assignable to type 'Node[]'.
- lib/MultiCompiler.js#L334
[NEW] error TS2339: Property 'close' does not exist on type 'unknown'.
- lib/MultiCompiler.js#L577
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Compiler | MultiCompiler'.
- lib/ProgressPlugin.js#L172
[NEW] error TS2322: Type 'string[] | (EntryObject & unknown[])' is not assignable to type 'string[]'.
- lib/config/normalization.js#L466
[NEW] error TS2322: Type 'unknown' is not assignable to type 'string'.
- lib/library/UmdLibraryPlugin.js#L102
- lib/library/UmdLibraryPlugin.js#L104
[NEW] error TS2322: Type 'string | string[] | (LibraryCustomUmdObject & unknown[])' is not assignable to type 'string | string[]'.
- lib/library/UmdLibraryPlugin.js#L103
[NEW] error TS2322: Type 'LibraryName' is not assignable to type 'string | string[]'.
- lib/library/UmdLibraryPlugin.js#L108
[NEW] error TS2345: Argument of type 'unknown[]' is not assignable to parameter of type 'string[]'.
- lib/library/UmdLibraryPlugin.js#L198
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'object'.
- lib/optimize/SplitChunksPlugin.js#L451
- lib/optimize/SplitChunksPlugin.js#L460

tsconfig.types.json

[NEW] error TS2322: Type '{ fileDependencies: string[] | (RuntimeValueOptions & unknown[]); }' is not assignable to type 'true | string[] | RuntimeValueOptions | undefined'.
- lib/DefinePlugin.js#L44
[NEW] error TS2339: Property 'fileDependencies' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L52
- lib/DefinePlugin.js#L66
- lib/DefinePlugin.js#L67
[NEW] error TS2339: Property 'contextDependencies' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L71
- lib/DefinePlugin.js#L72
[NEW] error TS2339: Property 'missingDependencies' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L76
- lib/DefinePlugin.js#L77
[NEW] error TS2339: Property 'buildDependencies' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L81
- lib/DefinePlugin.js#L82
[NEW] error TS2339: Property 'version' does not exist on type 'string[] | RuntimeValueOptions'.
- lib/DefinePlugin.js#L102
- lib/DefinePlugin.js#L103
- lib/DefinePlugin.js#L104
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- lib/ExternalModuleFactoryPlugin.js#L97
[NEW] error TS18046: 'firstItem' is of type 'unknown'.
- lib/ExternalModuleFactoryPlugin.js#L100
- lib/ExternalModuleFactoryPlugin.js#L101
- lib/ExternalModuleFactoryPlugin.js#L103
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Externals'.
- lib/ExternalModuleFactoryPlugin.js#L147
[NEW] error TS18046: 'c' is of type 'unknown'.
- lib/MultiCompiler.js#L62
- lib/MultiCompiler.js#L64
- lib/MultiCompiler.js#L68
- lib/MultiCompiler.js#L71
- lib/MultiCompiler.js#L111
- lib/MultiCompiler.js#L223
[NEW] error TS18046: 'compiler' is of type 'unknown'.
- lib/MultiCompiler.js#L90
- lib/MultiCompiler.js#L100
- lib/MultiCompiler.js#L120
- lib/MultiCompiler.js#L152
- lib/MultiCompiler.js#L161
- lib/MultiCompiler.js#L170
- lib/MultiCompiler.js#L179
- lib/MultiCompiler.js#L563
- lib/MultiCompiler.js#L563
- lib/MultiCompiler.js#L564
- lib/MultiCompiler.js#L577
[NEW] error TS7006: Parameter 'stats' implicitly has an 'any' type.
- lib/MultiCompiler.js#L90
[NEW] error TS2571: Object is of type 'unknown'.
- lib/MultiCompiler.js#L117
- lib/MultiCompiler.js#L127
- lib/MultiCompiler.js#L184
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Compiler'.
- lib/MultiCompiler.js#L220
[NEW] error TS2322: Type 'unknown' is not assignable to type 'Compiler'.
- lib/MultiCompiler.js#L228
[NEW] error TS2740: Type '{}' is missing the following properties from type 'Compiler': hooks, webpack, name, parentCompilation, and 56 more.
- lib/MultiCompiler.js#L229
[NEW] error TS2322: Type '{ compiler: unknown; setupResult: undefined; result: undefined; state: "blocked"; children: never[]; parents: never[]; }[]' is not assignable to type 'Node[]'.
- lib/MultiCompiler.js#L334
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'WatchOptions'.
- lib/MultiCompiler.js#L514
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Compiler | MultiCompiler'.
- lib/ProgressPlugin.js#L172
[NEW] error TS7053: Element implicitly has an 'any' type because expression of type 'number' can't be used to index type '(T[P] & null extends any ? Extract<(T[P] & null extends string | readonly any[] ? unknown : T[P] & null extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T[P] & null> | Extract<...> : never) | (T[P] & {} extends any ? Extract<...> | Extract<...> : never)'.
- lib/config/defaults.js#L97
[NEW] error TS2322: Type 'string[] | (EntryObject & unknown[])' is not assignable to type 'string[] | undefined'.
- lib/config/normalization.js#L466
[NEW] error TS2322: Type 'string | string[] | (LibraryCustomUmdObject & unknown[]) | undefined' is not assignable to type 'LibraryName'.
- lib/library/UmdLibraryPlugin.js#L99
[NEW] error TS2322: Type 'unknown' is not assignable to type 'string | undefined'.
- lib/library/UmdLibraryPlugin.js#L102
- lib/library/UmdLibraryPlugin.js#L104
[NEW] error TS2322: Type 'string | string[] | (LibraryCustomUmdObject & unknown[]) | undefined' is not assignable to type 'string | string[] | undefined'.
- lib/library/UmdLibraryPlugin.js#L103
[NEW] error TS2345: Argument of type 'unknown[]' is not assignable to parameter of type 'string[]'.
- lib/library/UmdLibraryPlugin.js#L198
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'object'.
- lib/optimize/SplitChunksPlugin.js#L451
- lib/optimize/SplitChunksPlugin.js#L460
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'OptimizationSplitChunksCacheGroup'.
- lib/optimize/SplitChunksPlugin.js#L456
[NEW] error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Object'.
- lib/stats/StatsPrinter.js#L204
[NEW] error TS2345: Argument of type '(readonly WebpackOptions[] & MultiCompilerOptions) | (WebpackOptions & unknown[])' is not assignable to parameter of type 'readonly WebpackOptions[]'.
- lib/webpack.js#L126
[NEW] error TS18046: 'options' is of type 'unknown'.
- lib/webpack.js#L129
- lib/webpack.js#L130
[MISSING] error TS2322: Type '{ compiler: Compiler; setupResult: undefined; result: undefined; state: "blocked"; children: never[]; parents: never[]; }[]' is not assignable to type 'Node[]'.
- lib/MultiCompiler.js#L334
[MISSING] error TS2322: Type 'string | string[] | undefined' is not assignable to type 'LibraryName'.
- lib/library/UmdLibraryPlugin.js#L99
[MISSING] error TS2322: Type 'string | LibraryCustomUmdObject' is not assignable to type 'string | undefined'.
- lib/library/UmdLibraryPlugin.js#L102
- lib/library/UmdLibraryPlugin.js#L104
[MISSING] error TS2345: Argument of type '{ _index: number; type: string; constructor?: Function | undefined; toString?: (() => string) | undefined; toLocaleString?: (() => string) | undefined; valueOf?: (() => Object) | undefined; hasOwnProperty?: ((v: PropertyKey) => boolean) | undefined; isPrototypeOf?: ((v: Object) => boolean) | undefined; propertyIsEnu...' is not assignable to parameter of type 'Object'.
- lib/stats/StatsPrinter.js#L205

TypeScript Bot (typescript-bot) · 2022-10-12T22:37:25Z

Nathan Shively-Sanders (@sandersn)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50454

_Metric	_main	₅₀₄₅₄	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{352,334k (± 0.02%)}	_{352,630k (± 0.02%)}	_{+296k (+ 0.08%)}	_352,386k	_352,736k
_{Parse Time}	_{1.89s (± 0.46%)}	_{1.90s (± 1.08%)}	_{+0.00s (+ 0.16%)}	_1.86s	_1.96s
_{Bind Time}	_{0.74s (± 0.78%)}	_{0.75s (± 0.66%)}	_{+0.00s (+ 0.40%)}	_0.74s	_0.76s
_{Check Time}	_{5.69s (± 0.73%)}	_{5.65s (± 0.33%)}	_{-0.04s (- 0.70%)}	_5.62s	_5.69s
_{Emit Time}	_{6.08s (± 0.66%)}	_{6.08s (± 0.67%)}	_{-0.00s (- 0.08%)}	_5.97s	_6.19s
_{Total Time}	_{14.41s (± 0.57%)}	_{14.37s (± 0.38%)}	_{-0.04s (- 0.31%)}	_14.20s	_14.48s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{198,279k (± 0.57%)}	_{198,700k (± 0.61%)}	_{+421k (+ 0.21%)}	_197,286k	_200,796k
_{Parse Time}	_{0.79s (± 0.87%)}	_{0.78s (± 0.71%)}	_{-0.00s (- 0.38%)}	_0.77s	_0.80s
_{Bind Time}	_{0.45s (± 1.09%)}	_{0.45s (± 0.89%)}	_{-0.00s (- 0.66%)}	_0.44s	_0.46s
_{Check Time}	_{6.50s (± 0.50%)}	_{6.51s (± 0.38%)}	_{+0.00s (+ 0.06%)}	_6.46s	_6.57s
_{Emit Time}	_{2.31s (± 1.09%)}	_{2.30s (± 0.71%)}	_{-0.01s (- 0.43%)}	_2.26s	_2.34s
_{Total Time}	_{10.05s (± 0.50%)}	_{10.04s (± 0.35%)}	_{-0.01s (- 0.10%)}	_9.95s	_10.12s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{331,133k (± 0.02%)}	_{331,125k (± 0.01%)}	_{-8k (- 0.00%)}	_331,077k	_331,202k
_{Parse Time}	_{1.42s (± 0.37%)}	_{1.43s (± 0.52%)}	_{+0.01s (+ 0.42%)}	_1.41s	_1.45s
_{Bind Time}	_{0.69s (± 0.86%)}	_{0.69s (± 0.75%)}	_{-0.00s (- 0.43%)}	_0.68s	_0.70s
_{Check Time}	_{5.47s (± 0.55%)}	_{5.48s (± 0.50%)}	_{+0.01s (+ 0.15%)}	_5.44s	_5.54s
_{Emit Time}	_{3.26s (± 0.55%)}	_{3.26s (± 0.79%)}	_{+0.00s (+ 0.06%)}	_3.23s	_3.32s
_{Total Time}	_{10.85s (± 0.44%)}	_{10.86s (± 0.39%)}	_{+0.01s (+ 0.13%)}	_10.78s	_10.97s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{294,050k (± 0.02%)}	_{294,087k (± 0.01%)}	_{+37k (+ 0.01%)}	_294,031k	_294,129k
_{Parse Time}	_{1.22s (± 1.53%)}	_{1.23s (± 1.09%)}	_{+0.01s (+ 0.49%)}	_1.20s	_1.26s
_{Bind Time}	_{0.64s (± 0.97%)}	_{0.64s (± 0.63%)}	_{0.00s ( 0.00%)}	_0.63s	_0.65s
_{Check Time}	_{5.12s (± 0.44%)}	_{5.13s (± 0.55%)}	_{+0.01s (+ 0.18%)}	_5.08s	_5.20s
_{Emit Time}	_{3.47s (± 0.64%)}	_{3.49s (± 0.71%)}	_{+0.02s (+ 0.49%)}	_3.43s	_3.55s
_{Total Time}	_{10.45s (± 0.42%)}	_{10.48s (± 0.47%)}	_{+0.03s (+ 0.31%)}	_10.34s	_10.56s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{439,350k (± 0.01%)}	_{439,362k (± 0.01%)}	_{+12k (+ 0.00%)}	_439,296k	_439,416k
_{Parse Time}	_{1.72s (± 1.24%)}	_{1.73s (± 0.96%)}	_{+0.01s (+ 0.47%)}	_1.69s	_1.76s
_{Bind Time}	_{0.54s (± 0.69%)}	_{0.54s (± 0.55%)}	_{+0.01s (+ 1.31%)}	_0.54s	_0.55s
_{Check Time}	_{12.52s (± 0.62%)}	_{12.65s (± 0.75%)}	_{+0.13s (+ 1.00%)}	_12.50s	_12.85s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.78s (± 0.53%)}	_{14.92s (± 0.63%)}	_{+0.14s (+ 0.94%)}	_14.76s	_15.11s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{554,310k (± 0.02%)}	_{555,844k (± 0.02%)}	_{+1,534k (+ 0.28%)}	_555,677k	_556,243k
_{Parse Time}	_{2.31s (± 0.28%)}	_{2.30s (± 0.36%)}	_{-0.00s (- 0.17%)}	_2.29s	_2.32s
_{Bind Time}	_{0.89s (± 1.49%)}	_{0.88s (± 1.37%)}	_{-0.01s (- 0.67%)}	_0.87s	_0.93s
_{Check Time}	_{1.43s (± 0.92%)}	_{1.47s (± 0.69%)}	_{+0.04s (+ 3.01%)}	_1.45s	_1.50s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{4.70s (± 0.23%)}	_{4.74s (± 0.27%)}	_{+0.04s (+ 0.87%)}	_4.71s	_4.76s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-126-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₄₅₄	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2022-10-13T00:09:16Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the top-repos suite comparing main and refs/pull/50454/merge:

Something interesting changed - please have a look.

Details

cheeriojs/cheerio

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2322: Type 'ChildNode[] | (S extends any ? Extract<(true extends false & S ? any : S extends string | readonly any[] ? unknown : S extends ArrayLike<infer U> | Iterable<...> ? U : unknown)[], S> | Extract<...> : never) | T[] | (NonNullable<...> extends any ? Extract<...> | Extract<...> : never) | undefined' is not assignable to type 'AnyNode[] | undefined'.
- src/load.ts#L165

conwnet/github1s

2 of 4 projects failed to build with the old tsc and were ignored

extensions/github1s/tsconfig.json

error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never)' is not assignable to type 'T[]'.
- extensions/github1s/src/providers/text-search.ts#L12

excalidraw/excalidraw

2 of 5 projects failed to build with the old tsc and were ignored

tsconfig-types.json

error TS2322: Type 'readonly (readonly [number, number])[] | number[][]' is not assignable to type 'readonly (readonly [number, number])[]'.
- src/data/restore.ts#L211

tsconfig.json

error TS2322: Type 'readonly (readonly [number, number])[] | number[][]' is not assignable to type 'readonly (readonly [number, number])[]'.
- src/data/restore.ts#L211

microsoft/vscode

3 of 53 projects failed to build with the old tsc and were ignored

build/tsconfig.build.json

error TS18046: 'e' is of type 'unknown'.
- build/azure-pipelines/mixin.ts#L51
error TS2322: Type 'IBuiltInExtension[] | ({ include?: IBuiltInExtension[] | undefined; exclude?: string[] | undefined; } & unknown[])' is not assignable to type 'IBuiltInExtension[]'.
- build/azure-pipelines/mixin.ts#L53

extensions/ipynb/tsconfig.json

error TS2345: Argument of type 'unknown[]' is not assignable to parameter of type 'string | string[]'.
- extensions/ipynb/src/deserializers.ts#L129
- extensions/ipynb/src/deserializers.ts#L144

extensions/markdown-language-features/tsconfig.browser.json

error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- extensions/markdown-language-features/src/markdownExtensions.ts#L18

extensions/markdown-language-features/tsconfig.json

error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- extensions/markdown-language-features/src/markdownExtensions.ts#L18

extensions/vscode-colorize-tests/tsconfig.json

error TS18046: 'd' is of type 'unknown'.
- extensions/vscode-colorize-tests/src/colorizer.test.ts#L31
- extensions/vscode-colorize-tests/src/colorizer.test.ts#L31

src/tsconfig.json

error TS2322: Type 'any[] | unknown[] | (Record<string, any> & unknown[])' is not assignable to type '(HTMLElement | Record<string, HTMLElement>)[] | undefined'.
- src/vs/base/browser/dom.ts#L1806
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L619
error TS18046: 'labelStr' is of type 'unknown'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L619
error TS2322: Type '{ data: { label: unknown; score: FuzzyScore; }; visibility: TreeVisibility.Visible | TreeVisibility.Recurse; }' is not assignable to type 'TreeFilterResult<FuzzyScore | LabelFuzzyScore>'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L622
error TS2769: No overload matches this call.
- src/vs/base/common/arrays.ts#L580
- src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L1475
- src/vs/workbench/services/environment/browser/environmentService.ts#L232
- src/vs/workbench/services/themes/common/colorThemeData.ts#L456
error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never)' is not assignable to type 'T[]'.
- src/vs/base/common/arrays.ts#L587
error TS2349: This expression is not callable.
- src/vs/editor/common/languageFeatureRegistry.ts#L23
- src/vs/workbench/contrib/tasks/common/taskConfiguration.ts#L1369
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'LanguageSelector | undefined'.
- src/vs/editor/common/languageSelector.ts#L30
error TS2322: Type 'unknown' is not assignable to type 'FuzzyAction'.
- src/vs/editor/standalone/common/monarch/monarchLexer.ts#L817
error TS2345: Argument of type 'string[] | (IBundledStrings & unknown[])' is not assignable to parameter of type 'string[]'.
- src/vs/nls.ts#L175
error TS2345: Argument of type 'IWindowOpenable[] | (IOpenEmptyWindowOptions & unknown[])' is not assignable to parameter of type 'IWindowOpenable[]'.
- src/vs/platform/native/electron-main/nativeHostMainService.ts#L144
- src/vs/workbench/services/host/browser/browserHostService.ts#L213
- src/vs/workbench/services/host/electron-sandbox/nativeHostService.ts#L71
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'WhenUser'.
- src/vs/server/node/remoteAgentEnvironmentImpl.ts#L262
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'IConfigurationNode'.
- src/vs/workbench/api/common/configurationExtensionPoint.ts#L266
error TS2345: Argument of type '(selector: DocumentSelector) => DocumentSelector' is not assignable to parameter of type '((value: string | DocumentFilter, index: number, array: readonly (string | DocumentFilter)[]) => void) & ((value: unknown, index: number, array: unknown[]) => void)'.
- src/vs/workbench/api/common/extHost.api.impl.ts#L220
error TS2345: Argument of type '{ (selector: undefined): undefined; (selector: DocumentSelector): LanguageSelector; (selector: DocumentSelector | undefined): LanguageSelector | undefined; }' is not assignable to parameter of type '((value: string | DocumentFilter, index: number, array: readonly (string | DocumentFilter)[]) => LanguageSelector | undefined) & ((value: unknown, index: number, array: unknown[]) => LanguageSelector | undefined)'.
- src/vs/workbench/api/common/extHostTypeConverters.ts#L1493
error TS2322: Type 'string[] | (ProcessExecutionOptions & unknown[])' is not assignable to type 'string[]'.
- src/vs/workbench/api/common/extHostTypes.ts#L2046
error TS2322: Type 'EditorInput[] | (ICloseEditorsFilter & unknown[])' is not assignable to type 'EditorInput[]'.
- src/vs/workbench/browser/parts/editor/editorGroupView.ts#L1649
error TS2322: Type 'string[] | ({ [kind: string]: boolean; } & unknown[])' is not assignable to type 'string[]'.
- src/vs/workbench/contrib/codeEditor/browser/saveParticipants.ts#L294
error TS2322: Type 'unknown' is not assignable to type 'string | undefined'.
- src/vs/workbench/contrib/issue/browser/issue.web.contribution.ts#L30
- src/vs/workbench/contrib/issue/browser/issue.web.contribution.ts#L45
error TS2322: Type 'OpenIssueReporterArgs | { extensionId: unknown; }' is not assignable to type 'Partial<IssueReporterData>'.
- src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts#L24
- src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts#L34
error TS2339: Property 'expression' does not exist on type 'unknown'.
- src/vs/workbench/contrib/markers/browser/markersFilterOptions.ts#L73
error TS2345: Argument of type '{ root: URI; expression: IExpression; }[] | (IExpression & unknown[])' is not assignable to parameter of type '{ root: URI; expression: IExpression; }[]'.
- src/vs/workbench/contrib/markers/browser/markersFilterOptions.ts#L100
error TS2339: Property 'join' does not exist on type 'never'.
- src/vs/workbench/contrib/notebook/common/services/notebookSimpleWorker.ts#L172
- src/vs/workbench/contrib/snippets/browser/snippetsFile.ts#L278
error TS7006: Parameter 'item' implicitly has an 'any' type.
- src/vs/workbench/contrib/tasks/common/taskConfiguration.ts#L1369
error TS2322: Type 'unknown[]' is not assignable to type 'ITerminalInstance[]'.
- src/vs/workbench/contrib/terminal/browser/terminalTabsList.ts#L587
error TS2345: Argument of type '(data: IDecorationData | IDecorationData[]) => string' is not assignable to parameter of type '((value: IDecorationData, index: number, array: IDecorationData[]) => string) & ((value: unknown, index: number, array: unknown[]) => string)'.
- src/vs/workbench/services/decorations/browser/decorationsService.ts#L30
error TS2345: Argument of type 'IDecorationData[] | (IDecorationData & unknown[])' is not assignable to parameter of type 'IDecorationData[]'.
- src/vs/workbench/services/decorations/browser/decorationsService.ts#L72
error TS2322: Type 'unknown[]' is not assignable to type 'string[]'.
- src/vs/workbench/services/extensions/browser/extensionUrlHandler.ts#L375
- src/vs/workbench/services/textMate/browser/abstractTextMateService.ts#L144
error TS2322: Type 'unknown[]' is not assignable to type 'string | boolean | ITextMateThemingRule[] | ITokenColorizationSetting | ISemanticTokenRules | undefined'.
- src/vs/workbench/services/themes/common/colorThemeData.ts#L456

src/tsconfig.monaco.json

error TS2322: Type 'any[] | unknown[] | (Record<string, any> & unknown[])' is not assignable to type '(HTMLElement | Record<string, HTMLElement>)[] | undefined'.
- src/vs/base/browser/dom.ts#L1806
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L619
error TS18046: 'labelStr' is of type 'unknown'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L619
error TS2322: Type '{ data: { label: unknown; score: FuzzyScore; }; visibility: TreeVisibility.Visible | TreeVisibility.Recurse; }' is not assignable to type 'TreeFilterResult<FuzzyScore | LabelFuzzyScore>'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L622
error TS2769: No overload matches this call.
- src/vs/base/common/arrays.ts#L580
error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never)' is not assignable to type 'T[]'.
- src/vs/base/common/arrays.ts#L587
error TS2349: This expression is not callable.
- src/vs/editor/common/languageFeatureRegistry.ts#L23
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'LanguageSelector | undefined'.
- src/vs/editor/common/languageSelector.ts#L30
error TS2322: Type 'unknown' is not assignable to type 'FuzzyAction'.
- src/vs/editor/standalone/common/monarch/monarchLexer.ts#L817
error TS2345: Argument of type 'string[] | (IBundledStrings & unknown[])' is not assignable to parameter of type 'string[]'.
- src/vs/nls.ts#L175

src/tsconfig.tsec.json

error TS2322: Type 'any[] | unknown[] | (Record<string, any> & unknown[])' is not assignable to type '(HTMLElement | Record<string, HTMLElement>)[] | undefined'.
- src/vs/base/browser/dom.ts#L1806
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L619
error TS18046: 'labelStr' is of type 'unknown'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L619
error TS2322: Type '{ data: { label: unknown; score: FuzzyScore; }; visibility: TreeVisibility.Visible | TreeVisibility.Recurse; }' is not assignable to type 'TreeFilterResult<FuzzyScore | LabelFuzzyScore>'.
- src/vs/base/browser/ui/tree/abstractTree.ts#L622
error TS2769: No overload matches this call.
- src/vs/base/common/arrays.ts#L580
- src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L1475
- src/vs/workbench/services/environment/browser/environmentService.ts#L232
- src/vs/workbench/services/themes/common/colorThemeData.ts#L456
error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never)' is not assignable to type 'T[]'.
- src/vs/base/common/arrays.ts#L587
error TS2349: This expression is not callable.
- src/vs/editor/common/languageFeatureRegistry.ts#L23
- src/vs/workbench/contrib/tasks/common/taskConfiguration.ts#L1369
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'LanguageSelector | undefined'.
- src/vs/editor/common/languageSelector.ts#L30
error TS2322: Type 'unknown' is not assignable to type 'FuzzyAction'.
- src/vs/editor/standalone/common/monarch/monarchLexer.ts#L817
error TS2345: Argument of type 'string[] | (IBundledStrings & unknown[])' is not assignable to parameter of type 'string[]'.
- src/vs/nls.ts#L175
error TS2345: Argument of type 'IWindowOpenable[] | (IOpenEmptyWindowOptions & unknown[])' is not assignable to parameter of type 'IWindowOpenable[]'.
- src/vs/platform/native/electron-main/nativeHostMainService.ts#L144
- src/vs/workbench/services/host/browser/browserHostService.ts#L213
- src/vs/workbench/services/host/electron-sandbox/nativeHostService.ts#L71
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'WhenUser'.
- src/vs/server/node/remoteAgentEnvironmentImpl.ts#L262
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'IConfigurationNode'.
- src/vs/workbench/api/common/configurationExtensionPoint.ts#L266
error TS2345: Argument of type '(selector: DocumentSelector) => DocumentSelector' is not assignable to parameter of type '((value: string | DocumentFilter, index: number, array: readonly (string | DocumentFilter)[]) => void) & ((value: unknown, index: number, array: unknown[]) => void)'.
- src/vs/workbench/api/common/extHost.api.impl.ts#L220
error TS2345: Argument of type '{ (selector: undefined): undefined; (selector: DocumentSelector): LanguageSelector; (selector: DocumentSelector | undefined): LanguageSelector | undefined; }' is not assignable to parameter of type '((value: string | DocumentFilter, index: number, array: readonly (string | DocumentFilter)[]) => LanguageSelector | undefined) & ((value: unknown, index: number, array: unknown[]) => LanguageSelector | undefined)'.
- src/vs/workbench/api/common/extHostTypeConverters.ts#L1493
error TS2322: Type 'string[] | (ProcessExecutionOptions & unknown[])' is not assignable to type 'string[]'.
- src/vs/workbench/api/common/extHostTypes.ts#L2046
error TS2322: Type 'EditorInput[] | (ICloseEditorsFilter & unknown[])' is not assignable to type 'EditorInput[]'.
- src/vs/workbench/browser/parts/editor/editorGroupView.ts#L1649
error TS2322: Type 'string[] | ({ [kind: string]: boolean; } & unknown[])' is not assignable to type 'string[]'.
- src/vs/workbench/contrib/codeEditor/browser/saveParticipants.ts#L294
error TS2322: Type 'unknown' is not assignable to type 'string | undefined'.
- src/vs/workbench/contrib/issue/browser/issue.web.contribution.ts#L30
- src/vs/workbench/contrib/issue/browser/issue.web.contribution.ts#L45
error TS2322: Type 'OpenIssueReporterArgs | { extensionId: unknown; }' is not assignable to type 'Partial<IssueReporterData>'.
- src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts#L24
- src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts#L34
error TS2339: Property 'expression' does not exist on type 'unknown'.
- src/vs/workbench/contrib/markers/browser/markersFilterOptions.ts#L73
error TS2345: Argument of type '{ root: URI; expression: IExpression; }[] | (IExpression & unknown[])' is not assignable to parameter of type '{ root: URI; expression: IExpression; }[]'.
- src/vs/workbench/contrib/markers/browser/markersFilterOptions.ts#L100
error TS2339: Property 'join' does not exist on type 'never'.
- src/vs/workbench/contrib/notebook/common/services/notebookSimpleWorker.ts#L172
- src/vs/workbench/contrib/snippets/browser/snippetsFile.ts#L278
error TS7006: Parameter 'item' implicitly has an 'any' type.
- src/vs/workbench/contrib/tasks/common/taskConfiguration.ts#L1369
error TS2322: Type 'unknown[]' is not assignable to type 'ITerminalInstance[]'.
- src/vs/workbench/contrib/terminal/browser/terminalTabsList.ts#L587
error TS2345: Argument of type '(data: IDecorationData | IDecorationData[]) => string' is not assignable to parameter of type '((value: IDecorationData, index: number, array: IDecorationData[]) => string) & ((value: unknown, index: number, array: unknown[]) => string)'.
- src/vs/workbench/services/decorations/browser/decorationsService.ts#L30
error TS2345: Argument of type 'IDecorationData[] | (IDecorationData & unknown[])' is not assignable to parameter of type 'IDecorationData[]'.
- src/vs/workbench/services/decorations/browser/decorationsService.ts#L72
error TS2322: Type 'unknown[]' is not assignable to type 'string[]'.
- src/vs/workbench/services/extensions/browser/extensionUrlHandler.ts#L375
- src/vs/workbench/services/textMate/browser/abstractTextMateService.ts#L144
error TS2322: Type 'unknown[]' is not assignable to type 'string | boolean | ITextMateThemingRule[] | ITokenColorizationSetting | ISemanticTokenRules | undefined'.
- src/vs/workbench/services/themes/common/colorThemeData.ts#L456

mobxjs/mobx

7 of 9 projects failed to build with the old tsc and were ignored

packages/mobx/tsconfig.json

error TS2322: Type 'this' is not assignable to type 'void'.
- packages/mobx/src/types/observablemap.ts#L349

n8n-io/n8n

6 of 9 projects failed to build with the old tsc and were ignored

packages/workflow/tsconfig.json

error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'NodeParameterValueType'.
- packages/workflow/src/Expression.ts#L480
- packages/workflow/src/Workflow.ts#L470
error TS2339: Property 'length' does not exist on type 'never'.
- packages/workflow/src/NodeHelpers.ts#L1136

neoclide/coc.nvim

tsconfig.json

error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never)' is not assignable to type 'T[]'.
- src/util/array.ts#L4

palantir/blueprint

4 of 27 projects failed to build with the old tsc and were ignored

packages/select/src/tsconfig.json

error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'T'.
- packages/select/src/components/query-list/queryList.tsx#L457
error TS2345: Argument of type 'unknown[]' is not assignable to parameter of type 'T[]'.
- packages/select/src/components/query-list/queryList.tsx#L508

packages/select/test/tsconfig.json

error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'T'.
- packages/select/src/components/query-list/queryList.tsx#L457
error TS2345: Argument of type 'unknown[]' is not assignable to parameter of type 'T[]'.
- packages/select/src/components/query-list/queryList.tsx#L508

pubkey/rxdb

6 of 10 projects failed to build with the old tsc and were ignored

config/tsconfig.types.json

error TS2322: Type 'string | undefined' is not assignable to type 'string'.
- src/plugins/dev-mode/check-schema.ts#L417
error TS2345: Argument of type 'readonly string[]' is not assignable to parameter of type 'string[]'.
- src/plugins/dexie/dexie-helper.ts#L226

tsconfig.json

error TS2322: Type 'string | undefined' is not assignable to type 'string'.
- src/plugins/dev-mode/check-schema.ts#L417
error TS2345: Argument of type 'readonly string[]' is not assignable to parameter of type 'string[]'.
- src/plugins/dexie/dexie-helper.ts#L226

react-hook-form/react-hook-form

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2339: Property 'startsWith' does not exist on type 'string | string[]'.
- src/logic/shouldSubscribeByName.ts#L16
error TS2345: Argument of type 'string | string[]' is not assignable to parameter of type 'string'.
- src/logic/shouldSubscribeByName.ts#L17
error TS2345: Argument of type '(Partial<FieldArray<TFieldValues, TFieldArrayName>>[] | (Partial<FieldArray<TFieldValues, TFieldArrayName>> extends any ? Extract<...> | Extract<...> : never) | Extract<...> | (Partial<...> | Partial<...>[])[])[number][]' is not assignable to parameter of type 'Partial<FieldArrayWithId<TFieldValues, TFieldArrayName, TKeyName>>[]'.
- src/useFieldArray.ts#L302
error TS2345: Argument of type '(Partial<FieldArray<TFieldValues, TFieldArrayName>>[] | (Partial<FieldArray<TFieldValues, TFieldArrayName>> extends any ? Extract<...> | Extract<...> : never) | Extract<...> | (Partial<...> | Partial<...>[])[])[number][]' is not assignable to parameter of type 'SetStateAction<Partial<unknown>[]>'.
- src/useFieldArray.ts#L303
error TS2345: Argument of type '(Partial<FieldArray<TFieldValues, TFieldArrayName>>[] | (Partial<FieldArray<TFieldValues, TFieldArrayName>> extends any ? Extract<...> | Extract<...> : never) | Extract<...> | (Partial<...> | Partial<...>[])[])[number][]' is not assignable to parameter of type 'Partial<unknown>[]'.
- src/useFieldArray.ts#L306
error TS2322: Type '(T | (T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<...> ? U : unknown)[], T> | Extract<...> : never) | Extract<...> | (T | T[])[])[number])[]' is not assignable to type 'T[]'.
- src/utils/append.ts#L4
error TS2322: Type '(T | (T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<...> ? U : unknown)[], T> | Extract<...> : never) | Extract<...> | (T | ... 1 more ... | undefined)[])[number])[]' is not assignable to type '(T | undefined)[]'.
- src/utils/insert.ts#L14
error TS2322: Type '((T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never) | Extract<...> | (T | T[])[])[number] | (T[] | ... 1 more ... | T[][])[number])[]' is not assignable to type 'T[]'.
- src/utils/prepend.ts#L4

ReactiveX/rxjs

8 of 13 projects failed to build with the old tsc and were ignored

src/tsconfig.cjs.spec.json

error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never) | (O extends any ? Extract<...> | Extract<...> : never) | Extract<...>' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14
error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8

src/tsconfig.esm5.rollup.json

error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never) | (O extends any ? Extract<...> | Extract<...> : never) | Extract<...>' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14
error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8

src/tsconfig.types.json

error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never) | (O extends any ? Extract<...> | Extract<...> : never) | Extract<...>' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14 in src/tsconfig.types.json
error TS2322: Type 'T[] | (T extends any ? Extract<(true extends false & T ? any : T extends string | readonly any[] ? unknown : T extends ArrayLike<infer U> | Iterable<infer U> ? U : unknown)[], T> | Extract<...> : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8 in src/tsconfig.types.json

statelyai/xstate

6 of 20 projects failed to build with the old tsc and were ignored

packages/xstate-inspect/tsconfig.json

error TS2322: Type 'TransitionsConfigArray<TContext, TEvent> | (TransitionsConfigMap<TContext, TEvent> extends any ? Extract<...> | Extract<...> : never) | Extract<...>' is not assignable to type '(TransitionConfig<TContext, EventObject> & { event: string; })[]'.
- packages/core/src/StateNode.ts#L2022 in packages/core/tsconfig.json

packages/xstate-test/tsconfig.json

error TS2322: Type 'TransitionsConfigArray<TContext, TEvent> | (TransitionsConfigMap<TContext, TEvent> extends any ? Extract<...> | Extract<...> : never) | Extract<...>' is not assignable to type '(TransitionConfig<TContext, EventObject> & { event: string; })[]'.
- packages/core/src/StateNode.ts#L2022 in packages/core/tsconfig.json

styled-components/styled-components

1 of 2 projects failed to build with the old tsc and were ignored

packages/styled-components/tsconfig.json

error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Interpolation<Props>'.
- packages/styled-components/src/utils/flatten.ts#L55
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Interpolation<ExecutionContext & Props>'.
- packages/styled-components/src/utils/flatten.ts#L58

typeorm/typeorm

tsconfig.json

error TS18046: 'options' is of type 'unknown'.
error TS2322: Type '_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity>[] | (_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity> extends any ? Extract<...> | Extract<...> : never) | Extract<...>' is not assignable to type '_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity>[]'.
- src/entity-manager/EntityManager.ts#L699
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Object'.
error TS2345: Argument of type '_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity>[] | (_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity> extends any ? Extract<...> | Extract<...> : never) | Extract<...>' is not assignable to parameter of type 'ObjectLiteral[]'.
- src/entity-manager/MongoEntityManager.ts#L251
error TS7053: Element implicitly has an 'any' type because expression of type 'string | number | symbol' can't be used to index type 'string | number | symbol'.
- src/entity-manager/MongoEntityManager.ts#L1034
error TS18046: 'joinColumnOption' is of type 'unknown'.
error TS2339: Property 'indexOf' does not exist on type 'never'.
- src/metadata-args/MetadataArgsStorage.ts#L270
- src/metadata-args/MetadataArgsStorage.ts#L284
error TS2322: Type 'unknown[]' is not assignable to type '(string | number)[]'.
- src/metadata/ColumnMetadata.ts#L441
error TS18046: 'v' is of type 'unknown'.
- src/metadata/ColumnMetadata.ts#L664
error TS2322: Type 'unknown[]' is not assignable to type 'ObjectLiteral[]'.
- src/persistence/EntityPersistExecutor.ts#L63
- src/query-builder/QueryBuilder.ts#L1515
error TS2322: Type 'string[] | ({ columns?: string[] | undefined; overwrite?: string[] | undefined; conflict_target?: string | string[] | undefined; } & unknown[])' is not assignable to type 'string[] | undefined'.
- src/query-builder/InsertQueryBuilder.ts#L389
error TS2322: Type 'unknown[] | ObjectLiteral[] | (ObjectLiteral & unknown[])' is not assignable to type 'ObjectLiteral[]'.
- src/query-builder/InsertQueryBuilder.ts#L983
error TS2345: Argument of type 'unknown[]' is not assignable to parameter of type 'ObjectLiteral[]'.
error TS2322: Type 'E1[] | (E1 extends any ? Extract<(true extends false & E1 ? any : E1 extends string | readonly any[] ? unknown : E1 extends ArrayLike<infer U> | Iterable<...> ? U : unknown)[], E1> | Extract<...> : never)' is not assignable to type 'E1[]'.
- src/query-builder/RelationIdLoader.ts#L75
error TS2322: Type 'E2[] | (E2 extends any ? Extract<(true extends false & E2 ? any : E2 extends string | readonly any[] ? unknown : E2 extends ArrayLike<infer U> | Iterable<...> ? U : unknown)[], E2> | Extract<...> : never)' is not assignable to type 'E2[]'.
- src/query-builder/RelationIdLoader.ts#L102
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'ObjectLiteral'.
error TS2345: Argument of type 'FindOptionsRelationByString | (FindOptionsRelations<any> & unknown[])' is not assignable to parameter of type 'string[]'.
- src/query-builder/SelectQueryBuilder.ts#L2955
- src/query-builder/SelectQueryBuilder.ts#L3420
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'FindOptionsWhere<any>'.
- src/query-builder/SelectQueryBuilder.ts#L4026
error TS2322: Type 'Entity[] | (Entity extends any ? Extract<(true extends false & Entity ? any : Entity extends string | readonly any[] ? unknown : Entity extends ArrayLike<...> | Iterable<...> ? U : unknown)[], Entity> | Extract<...> : never)' is not assignable to type 'Entity[]'.
- src/query-builder/SoftDeleteQueryBuilder.ts#L411
- src/query-builder/UpdateQueryBuilder.ts#L442

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2349: This expression is not callable.
- app/utils/colors.ts#L29 in app/tsconfig.json

graphemecluster (graphemecluster) · 2022-10-13T12:44:27Z

Heck no. It seems that without making it looser it won’t be a solution.

graphemecluster (graphemecluster) · 2022-10-14T02:06:58Z

I've just tinkered with it a bit. Nathan Shively-Sanders (@sandersn) Could you please give it another try?

Nathan Shively-Sanders (sandersn) · 2022-10-17T18:44:23Z

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2022-10-17T18:44:26Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based user code test suite on this PR at dc97890. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-10-17T18:44:26Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the abridged perf test suite on this PR at dc97890. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-10-17T18:44:26Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based top-repos suite on this PR at dc97890. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-10-17T18:44:26Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at dc97890. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-10-17T18:58:25Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the user test suite comparing main and refs/pull/50454/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.json

[NEW] error TS2322: Type '{ compiler: any; setupResult: any; result: any; state: string; children: any[]; parents: any[]; }[]' is not assignable to type 'Node[]'.
- lib/MultiCompiler.js#L334

tsconfig.types.json

[NEW] error TS7006: Parameter 'stats' implicitly has an 'any' type.
- lib/MultiCompiler.js#L90
[NEW] error TS2322: Type '{ compiler: any; setupResult: undefined; result: undefined; state: "blocked"; children: never[]; parents: never[]; }[]' is not assignable to type 'Node[]'.
- lib/MultiCompiler.js#L334
[NEW] error TS7053: Element implicitly has an 'any' type because expression of type 'number' can't be used to index type '(T[P] & null extends any ? (T[P] & null extends string | readonly any[] ? never : T[P] & null extends ArrayLike<infer U> | Iterable<infer U> ? Extract<...> : never) | ({} extends Required<...> ? never : Extract<...>) : never) | (T[P] & {} extends any ? (true extends false & T[P] ? Extract<...> : T[P] & {} extends st...'.
- lib/config/defaults.js#L97
[MISSING] error TS2322: Type '{ compiler: Compiler; setupResult: undefined; result: undefined; state: "blocked"; children: never[]; parents: never[]; }[]' is not assignable to type 'Node[]'.
- lib/MultiCompiler.js#L334

TypeScript Bot (typescript-bot) · 2022-10-17T19:02:52Z

Nathan Shively-Sanders (@sandersn)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50454

_Metric	_main	₅₀₄₅₄	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{352,473k (± 0.02%)}	_{353,198k (± 0.01%)}	_{+726k (+ 0.21%)}	_353,151k	_353,247k
_{Parse Time}	_{1.90s (± 0.66%)}	_{1.91s (± 1.03%)}	_{+0.01s (+ 0.58%)}	_1.87s	_1.95s
_{Bind Time}	_{0.75s (± 0.91%)}	_{0.75s (± 0.66%)}	_{-0.00s (- 0.00%)}	_0.74s	_0.76s
_{Check Time}	_{5.71s (± 0.60%)}	_{5.71s (± 0.61%)}	_{-0.00s (- 0.02%)}	_5.64s	_5.77s
_{Emit Time}	_{6.16s (± 0.94%)}	_{6.13s (± 0.61%)}	_{-0.04s (- 0.57%)}	_6.06s	_6.23s
_{Total Time}	_{14.51s (± 0.48%)}	_{14.49s (± 0.44%)}	_{-0.03s (- 0.19%)}	_14.37s	_14.70s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{197,773k (± 0.38%)}	_{198,113k (± 0.50%)}	_{+340k (+ 0.17%)}	_197,406k	_200,787k
_{Parse Time}	_{0.79s (± 0.76%)}	_{0.79s (± 0.74%)}	_{+0.00s (+ 0.25%)}	_0.78s	_0.80s
_{Bind Time}	_{0.46s (± 1.04%)}	_{0.46s (± 0.82%)}	_{-0.00s (- 0.44%)}	_0.45s	_0.46s
_{Check Time}	_{6.48s (± 0.59%)}	_{6.47s (± 0.48%)}	_{-0.01s (- 0.17%)}	_6.41s	_6.56s
_{Emit Time}	_{2.28s (± 0.90%)}	_{2.31s (± 1.32%)}	_{+0.03s (+ 1.40%)}	_2.28s	_2.42s
_{Total Time}	_{10.01s (± 0.53%)}	_{10.03s (± 0.42%)}	_{+0.02s (+ 0.20%)}	_9.92s	_10.11s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{331,123k (± 0.01%)}	_{331,137k (± 0.01%)}	_{+13k (+ 0.00%)}	_331,078k	_331,212k
_{Parse Time}	_{1.44s (± 0.84%)}	_{1.44s (± 0.74%)}	_{+0.00s (+ 0.07%)}	_1.41s	_1.46s
_{Bind Time}	_{0.70s (± 0.86%)}	_{0.69s (± 0.71%)}	_{-0.00s (- 0.14%)}	_0.69s	_0.71s
_{Check Time}	_{5.47s (± 0.86%)}	_{5.47s (± 0.44%)}	_{-0.01s (- 0.13%)}	_5.42s	_5.54s
_{Emit Time}	_{3.25s (± 0.60%)}	_{3.25s (± 0.45%)}	_{+0.01s (+ 0.28%)}	_3.21s	_3.29s
_{Total Time}	_{10.85s (± 0.64%)}	_{10.85s (± 0.26%)}	_{-0.00s (- 0.00%)}	_10.78s	_10.91s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{294,076k (± 0.02%)}	_{294,022k (± 0.02%)}	_{-54k (- 0.02%)}	_293,860k	_294,120k
_{Parse Time}	_{1.23s (± 2.00%)}	_{1.23s (± 1.27%)}	_{-0.00s (- 0.24%)}	_1.18s	_1.26s
_{Bind Time}	_{0.64s (± 0.35%)}	_{0.65s (± 0.73%)}	_{+0.01s (+ 0.94%)}	_0.64s	_0.66s
_{Check Time}	_{5.13s (± 0.58%)}	_{5.12s (± 0.40%)}	_{-0.01s (- 0.20%)}	_5.09s	_5.18s
_{Emit Time}	_{3.49s (± 0.85%)}	_{3.48s (± 0.58%)}	_{-0.01s (- 0.17%)}	_3.44s	_3.53s
_{Total Time}	_{10.48s (± 0.48%)}	_{10.47s (± 0.41%)}	_{-0.01s (- 0.10%)}	_10.40s	_10.56s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{438,355k (± 0.01%)}	_{438,383k (± 0.01%)}	_{+28k (+ 0.01%)}	_438,327k	_438,436k
_{Parse Time}	_{1.73s (± 1.38%)}	_{1.75s (± 1.37%)}	_{+0.01s (+ 0.75%)}	_1.69s	_1.79s
_{Bind Time}	_{0.54s (± 0.55%)}	_{0.55s (± 0.87%)}	_{+0.00s (+ 0.92%)}	_0.54s	_0.56s
_{Check Time}	_{12.54s (± 1.09%)}	_{12.52s (± 0.33%)}	_{-0.02s (- 0.15%)}	_12.39s	_12.61s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.82s (± 1.07%)}	_{14.81s (± 0.30%)}	_{-0.00s (- 0.01%)}	_14.69s	_14.94s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{554,419k (± 0.02%)}	_{555,329k (± 0.01%)}	_{+911k (+ 0.16%)}	_555,151k	_555,547k
_{Parse Time}	_{2.31s (± 0.49%)}	_{2.32s (± 0.28%)}	_{+0.01s (+ 0.39%)}	_2.30s	_2.33s
_{Bind Time}	_{0.90s (± 2.16%)}	_{0.90s (± 2.41%)}	_{-0.00s (- 0.22%)}	_0.87s	_0.96s
_{Check Time}	_{1.42s (± 0.86%)}	_{1.47s (± 1.06%)}	_{+0.05s (+ 3.38%)}	_1.42s	_1.50s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{4.70s (± 0.31%)}	_{4.75s (± 0.36%)}	_{+0.05s (+ 1.11%)}	_4.71s	_4.79s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-126-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₄₅₄	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2022-10-17T20:25:11Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the top-repos suite comparing main and refs/pull/50454/merge:

Something interesting changed - please have a look.

Details

cheeriojs/cheerio

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2322: Type 'ChildNode[] | (S extends any ? (true extends false & S ? Extract<any[], S> : S extends string | readonly any[] ? never : S extends ArrayLike<...> | Iterable<...> ? Extract<...> : never) | (true extends false & S ? never : {} extends Required<...> ? S & any[] : Extract<...>) : never) | T[] | (NonNullable<...> extends...' is not assignable to type 'AnyNode[] | undefined'.
- src/load.ts#L165

conwnet/github1s

2 of 4 projects failed to build with the old tsc and were ignored

extensions/github1s/tsconfig.json

error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never)' is not assignable to type 'T[]'.
- extensions/github1s/src/providers/text-search.ts#L12

excalidraw/excalidraw

2 of 5 projects failed to build with the old tsc and were ignored

tsconfig-types.json

error TS2322: Type 'readonly (readonly [number, number])[] | number[][]' is not assignable to type 'readonly (readonly [number, number])[]'.
- src/data/restore.ts#L211

tsconfig.json

error TS2322: Type 'readonly (readonly [number, number])[] | number[][]' is not assignable to type 'readonly (readonly [number, number])[]'.
- src/data/restore.ts#L211

microsoft/vscode

4 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.monaco.json

error TS2345: Argument of type '(_: T) => U' is not assignable to parameter of type '((value: any, index: number, array: any[]) => U) & ((value: unknown, index: number, array: unknown[]) => U) & ((value: any, index: number, array: readonly any[]) => U) & ((value: T, index: number, array: T[]) => U)'.
- src/vs/base/common/arrays.ts#L580
error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never)' is not assignable to type 'T[]'.
- src/vs/base/common/arrays.ts#L587

src/tsconfig.tsec.json

error TS2345: Argument of type '(_: T) => U' is not assignable to parameter of type '((value: any, index: number, array: any[]) => U) & ((value: unknown, index: number, array: unknown[]) => U) & ((value: any, index: number, array: readonly any[]) => U) & ((value: T, index: number, array: T[]) => U)'.
- src/vs/base/common/arrays.ts#L580
error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never)' is not assignable to type 'T[]'.
- src/vs/base/common/arrays.ts#L587
error TS2339: Property 'join' does not exist on type 'never'.
- src/vs/workbench/contrib/notebook/common/services/notebookSimpleWorker.ts#L172
- src/vs/workbench/contrib/snippets/browser/snippetsFile.ts#L277

n8n-io/n8n

6 of 9 projects failed to build with the old tsc and were ignored

packages/workflow/tsconfig.json

error TS2339: Property 'length' does not exist on type 'never'.
- packages/workflow/src/NodeHelpers.ts#L1136

neoclide/coc.nvim

tsconfig.json

error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never)' is not assignable to type 'T[]'.
- src/util/array.ts#L4

react-hook-form/react-hook-form

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2339: Property 'startsWith' does not exist on type 'string | string[]'.
- src/logic/shouldSubscribeByName.ts#L16
error TS2345: Argument of type 'string | string[]' is not assignable to parameter of type 'string'.
- src/logic/shouldSubscribeByName.ts#L17
error TS2345: Argument of type '(Partial<FieldArray<TFieldValues, TFieldArrayName>>[] | (Partial<FieldArray<TFieldValues, TFieldArrayName>> extends any ? (true extends false & Partial<...> ? Extract<...> : Partial<...> extends string | readonly any[] ? never : Partial<...> extends ArrayLike<...> | Iterable<...> ? Extract<...> : never) | (true exte...' is not assignable to parameter of type 'Partial<FieldArrayWithId<TFieldValues, TFieldArrayName, TKeyName>>[]'.
- src/useFieldArray.ts#L302
error TS2345: Argument of type '(Partial<FieldArray<TFieldValues, TFieldArrayName>>[] | (Partial<FieldArray<TFieldValues, TFieldArrayName>> extends any ? (true extends false & Partial<...> ? Extract<...> : Partial<...> extends string | readonly any[] ? never : Partial<...> extends ArrayLike<...> | Iterable<...> ? Extract<...> : never) | (true exte...' is not assignable to parameter of type 'SetStateAction<Partial<unknown>[]>'.
- src/useFieldArray.ts#L303
error TS2345: Argument of type '(Partial<FieldArray<TFieldValues, TFieldArrayName>>[] | (Partial<FieldArray<TFieldValues, TFieldArrayName>> extends any ? (true extends false & Partial<...> ? Extract<...> : Partial<...> extends string | readonly any[] ? never : Partial<...> extends ArrayLike<...> | Iterable<...> ? Extract<...> : never) | (true exte...' is not assignable to parameter of type 'Partial<unknown>[]'.
- src/useFieldArray.ts#L306
error TS2322: Type '(T | (T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never) | (T | T[])[])[number])[]' is not assignable to type 'T[]'.
- src/utils/append.ts#L4
error TS2322: Type '(T | (T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never) | (T | ... 1 more ... | undefin...' is not assignable to type '(T | undefined)[]'.
- src/utils/insert.ts#L14
error TS2322: Type '(T | T[] | (T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<...> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never) | (T | T[])[])[number])[]' is not assignable to type 'T[]'.
- src/utils/prepend.ts#L4

ReactiveX/rxjs

8 of 13 projects failed to build with the old tsc and were ignored

src/tsconfig.cjs.spec.json

error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never) | (O extends any ? (true extends fals...' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14
error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8

src/tsconfig.esm5.rollup.json

error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never) | (O extends any ? (true extends fals...' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14
error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8

src/tsconfig.types.json

error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never) | (O extends any ? (true extends fals...' is not assignable to type 'T[]'.
- src/internal/util/argsArgArrayOrObject.ts#L14 in src/tsconfig.types.json
error TS2322: Type 'T[] | (T extends any ? (true extends false & T ? Extract<any[], T> : T extends string | readonly any[] ? never : T extends ArrayLike<infer U> | Iterable<...> ? Extract<...> : never) | (true extends false & T ? never : {} extends Required<...> ? T & any[] : Extract<...>) : never)' is not assignable to type 'T[]'.
- src/internal/util/argsOrArgArray.ts#L8 in src/tsconfig.types.json

refined-github/refined-github

tsconfig.json

error TS2322: Type 'Item[] | (Item extends any ? (true extends false & Item ? Extract<any[], Item> : Item extends string | readonly any[] ? never : Item extends ArrayLike<...> | Iterable<...> ? Extract<...> : never) | (true extends false & Item ? never : {} extends Required<...> ? Item & any[] : Extract<...>) : never)' is not assignable to type 'Item[]'.
- source/feature-manager.tsx#L161

statelyai/xstate

6 of 20 projects failed to build with the old tsc and were ignored

packages/xstate-inspect/tsconfig.json

error TS2322: Type 'TransitionsConfigArray<TContext, TEvent> | (TransitionsConfigMap<TContext, TEvent> extends any ? (true extends false & TransitionsConfigMap<...> ? Extract<...> : TransitionsConfigMap<...> extends string | readonly any[] ? never : TransitionsConfigMap<...> extends ArrayLike<...> | Iterable<...> ? Extract<...> : never...' is not assignable to type '(TransitionConfig<TContext, EventObject> & { event: string; })[]'.
- packages/core/src/StateNode.ts#L2022 in packages/core/tsconfig.json

packages/xstate-test/tsconfig.json

error TS2322: Type 'TransitionsConfigArray<TContext, TEvent> | (TransitionsConfigMap<TContext, TEvent> extends any ? (true extends false & TransitionsConfigMap<...> ? Extract<...> : TransitionsConfigMap<...> extends string | readonly any[] ? never : TransitionsConfigMap<...> extends ArrayLike<...> | Iterable<...> ? Extract<...> : never...' is not assignable to type '(TransitionConfig<TContext, EventObject> & { event: string; })[]'.
- packages/core/src/StateNode.ts#L2022 in packages/core/tsconfig.json

typeorm/typeorm

tsconfig.json

error TS2322: Type '_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity>[] | (_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity> extends any ? (true extends false & _QueryDeepPartialEntity<...> ? Extract<...> : _QueryDeepPartialEntity<...> extends string | readonly any[] ? never : _QueryDeepPar...' is not assignable to type '_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity>[]'.
- src/entity-manager/EntityManager.ts#L699
error TS2345: Argument of type '_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity>[] | (_QueryDeepPartialEntity<ObjectLiteral extends Entity ? unknown : Entity> extends any ? (true extends false & _QueryDeepPartialEntity<...> ? Extract<...> : _QueryDeepPartialEntity<...> extends string | readonly any[] ? never : _QueryDeepPar...' is not assignable to parameter of type 'ObjectLiteral[]'.
- src/entity-manager/MongoEntityManager.ts#L251
error TS7053: Element implicitly has an 'any' type because expression of type 'string | number | symbol' can't be used to index type 'string | number | symbol'.
- src/entity-manager/MongoEntityManager.ts#L1034
error TS2339: Property 'indexOf' does not exist on type 'never'.
- src/metadata-args/MetadataArgsStorage.ts#L270
- src/metadata-args/MetadataArgsStorage.ts#L284

wenyan-lang/wenyan

tsconfig.json

error TS2339: Property 'map' does not exist on type 'never'.
- src/execute.ts#L18

graphemecluster (graphemecluster) · 2022-10-18T17:07:01Z

Actually most of the cases above just work by adding an extends any constraint on the generic parameter (see the test cases I added). Perhaps it’s a separated but related problem. Nathan Shively-Sanders (@sandersn), or perhaps Ryan Cavanaugh (@RyanCavanaugh), sorry to bother you again, but could you please inspect this?

Nathan Shively-Sanders (sandersn) · 2022-10-18T23:57:09Z

graphemecluster (@graphemecluster) can you explain what the failures are like that would have been fixed by adding extends any? 4.8 did make unconstrained type parameters implicitly extend unknown instead of {}, and a common workaround was to add an explicit extends any. Maybe that's related.

Could you also add a detailed explanation of the new type of isArray? I read the type and couldn't understand the reason for almost any of its intricacies.

graphemecluster (graphemecluster) · 2022-10-19T12:37:21Z

Nathan Shively-Sanders (@sandersn)
A rough explanation looks like:

type ToArray<T> =
    // Distribute it
    T extends any ?
        (
            // if T == any, return any[]
            true extends false & T ? Extract<any[], T> : 
            // if T is an array-like or iterable object but not string or array, return U[]
            T extends string | readonly any[] ? never :
            T extends ArrayLike<infer U> | Iterable<infer U> ? Extract<U[], T> :
            // fallback to the bottom cases
            never
        ) | (
            // T == any has been covered above, so skip it
            true extends false & T ? never : 
            // if T is any Record-like object (object with only index signature),
            // intersect it with any array (this case should be rare, but a use
            // case was found in test suite and being added to the test case file)
            {} extends Required<T> ? T & any[] :
            // otherwise, for cases not being covered by the above, extract all
            // the arrays and readonly arrays out and dispose the remaining
            Extract<T, readonly any[]>
        )
    : never;

There are no special reasons to separate the cases into two, but without this TypeScript may not think the result type is an array and fires error on test cases fc and fe (also see the earlier test suite result).
The use of Extract is to make sure that the predicate is assignable to the parameter type. (Using intersection instead, the result would be awful.)

Actually using extends unknown instead of extends any in test cases ff and fg does not affect the result at all, but it's not the case when the constraint is removed. That means there must be some problems with generic parameters without constraint in TypeScript.

graphemecluster (graphemecluster) · 2022-10-19T12:53:48Z

I just noticed that replacing Extract<T, readonly any[]> with T extends readonly any[] ? T : never will make test cases fc and fe fail. I can hardly understand why.

Nathan Shively-Sanders (sandersn) · 2022-10-19T16:28:46Z

My feeling is that this problem is too complex to have a fix that I'm comfortable shipping in the standard lib. At least one that doesn't break existing code.

If you can show that there aren't going to be many breaks across the ecosystem of packages, and that compilation won't slow down, it would still be worthwhile. But I think that's too much effort for this.

graphemecluster (graphemecluster) · 2022-10-21T11:32:28Z

Nathan Shively-Sanders (@sandersn) If possible, might you try running the test suite in 4.7.4 before #51242 is solved?

Nathan Shively-Sanders (sandersn) · 2023-04-11T23:53:40Z

I talked with Ryan about this again, and we don't think there's any way that a conditional return type will work. Specifically, it won't be usable in higher-order, generic uses. But it's complex enough that there are likely other corner-case failures I haven't thought of. I think this PR should be closed.

However, we want to work on the other lib fix PRs and bring them to the Typescript design meeting after finding out how well they work on existing code. I'll start with the smallest one and start user tests, etc.

graphemecluster (graphemecluster) · 2023-04-12T16:49:24Z

Thanks for picking this up. Now that I agree eventually all solutions tinkering with the lib won’t be perfect, I am going to root around in the compiler for a better way out. Let’s close this PR until then.

lib Types and Documentations Fix

f660c25

TypeScript Bot (typescript-bot) added For Backlog Bug PRs that fix a backlog bug For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 25, 2022

graphemecluster (graphemecluster) mentioned this pull request Aug 25, 2022

lib Types and Documentations Fix #49855

Closed

Nathan Shively-Sanders (sandersn) self-assigned this Sep 13, 2022

Nathan Shively-Sanders (sandersn) requested review from Daniel Rosenwasser (DanielRosenwasser) and Nathan Shively-Sanders (sandersn) and removed request for Nathan Shively-Sanders (sandersn) September 13, 2022 23:25

Fix and add test cases based on test suite

1928480

graphemecluster (graphemecluster) added 2 commits September 18, 2022 18:34

Shorten the definition

92f48e8

Merge main branch: Array line number changes

48fe04f

graphemecluster (graphemecluster) changed the title ~~lib Types and Documentations Fix, Part 6/6~~ lib Fix Part 6/6 – Array.isArray Oct 9, 2022

Merge main branch: Array line number changes

2149ae6

Another Attempt

dc97890

This was referenced Oct 20, 2022

Array.isArray type narrows to any[] for ReadonlyArray<T> #17002

Open

Regression in conditional type predicate #51242

Closed

Merge remote-tracking branch 'upstream/main' into implement49733-part6

bf07a20

graphemecluster (graphemecluster) closed this Apr 12, 2023

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

graphemecluster (graphemecluster) commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

General Information

Part 6/6, Array.isArray

Uh oh!

Nathan Shively-Sanders (sandersn) commented Sep 13, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan Shively-Sanders (sandersn) commented Sep 13, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 13, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 14, 2022

Uh oh!

graphemecluster (graphemecluster) commented Sep 15, 2022

Uh oh!

graphemecluster (graphemecluster) commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan Shively-Sanders (sandersn) commented Oct 12, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 12, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 12, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Oct 13, 2022

Uh oh!

graphemecluster (graphemecluster) commented Oct 13, 2022

Uh oh!

graphemecluster (graphemecluster) commented Aug 25, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Sep 13, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Sep 13, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Sep 13, 2022 •

edited

Loading

graphemecluster (graphemecluster) commented Sep 15, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Oct 12, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Oct 12, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Oct 12, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Oct 12, 2022 •

edited

Loading