ci: run unit tests and builds on push to main - #325
Merged
Conversation
All functional CI was pull_request-only, so the merged result on main was never tested — a PR based on stale main could merge into an untested combination. Run unit + build jobs on push to main to catch that. Acceptance tests stay PR-gated (live APIs, slow, flaky). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01UQV9qtvETd62qg2iDRR6kY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the
testworkflow (unit tests + cross-platform builds) on push tomain, not only on pull requests.Why
Today all functional CI is
pull_request-only, so nothing runs on the merged result onmain. A PR branch based on stalemaincan merge into a combination that git accepts textually but no PR run ever exercised — semantic drift can land untested. Running unit + build on push tomaincatches that class immediately and cheaply.Acceptance tests are intentionally left PR-gated: they hit live Hookdeck APIs and are slow (~12 min) and occasionally flaky, so running them on every
mainpush would be noisy and costly.Follow-ups (not in this PR)
main.invocation_idand trips the telemetry-consistency assertion), then add an acceptance gate on thereleaseworkflow.🤖 Generated with Claude Code
https://claude.ai/code/session_01UQV9qtvETd62qg2iDRR6kY