fix: upgrade all node core library dependencies to their latest node 22 version - #9084
Open
danieljbruce wants to merge 14 commits into
Open
fix: upgrade all node core library dependencies to their latest node 22 version#9084danieljbruce wants to merge 14 commits into
danieljbruce wants to merge 14 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates multiple package.json files across the repository, upgrading several dependencies and devDependencies to newer major versions (such as @google-cloud/projectify, @google-cloud/promisify, google-auth-library, and gaxios). It also bumps the minimum Node.js engine requirement to >=22 for multiple packages and samples. There are no review comments, so I have no feedback to provide.
…e gaxios" This reverts commit 17b07c0.
…//github.com/googleapis/google-cloud-node into node-22-bump-dependencies-for-core-libraries # Conflicts: # core/packages/gcp-metadata/package.json # core/packages/google-auth-library-nodejs/package.json # core/packages/nodejs-googleapis-common/package.json
…e generated packages" This reverts commit 6ffcb52.
…//github.com/googleapis/google-cloud-node into node-22-bump-dependencies-for-core-libraries
This reverts commit e20b652.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One thing we should do in addition to the plan outlined for the Node upgrade is we should upgrade the dependencies of the core libraries to match versions that correspond to Node v22. We do this for our generated packages so it is reasonable to do it for the core packages too. This actually addresses #9078 (comment) removing a compiler error that should be addressed.
Generated a script to update the dependencies and ran it.
An additional detail is that we exclude the dependencies for generated packages for now since we have not confirmed they have been released with the major upgrade yet and we also exclude upgrading gaxios since it was not upgraded to Node 22 yet.
Impact
Ensures Node versions for core library dependencies match the core library node versions (that they are all v22).