Ruby: Exclude vendored library parameters from taint sources. - #22282
Open
aschackmull wants to merge 2 commits into
Open
Ruby: Exclude vendored library parameters from taint sources.#22282aschackmull wants to merge 2 commits into
aschackmull wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The focused change matches the described false-positive scenario without introducing review findings.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Excludes vendored Ruby gems from library-input taint source modeling, reducing false positives across five security queries.
Changes:
- Detects gemspecs beneath a
vendordirectory. - Excludes their parameters from
getALibraryInput().
File summaries
| File | Description |
|---|---|
ruby/ql/lib/codeql/ruby/frameworks/core/Gem.qll |
Filters vendored gems from external library inputs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 queries (
PolynomialReDoS.ql,MissingFullAnchor.ql,UnsafeCodeConstruction.ql,UnsafeHtmlConstruction.ql, andUnsafeShellCommandConstruction.ql) useGem::getALibraryInput()as a taint source, but when the gem is vendored this leads to FPs, since then those parameters aren't external input, but instead just ordinary call targets from a fixed set of call sites.