Skip to content

Update to Ag Grid 35 - #14972

Open
kazcw wants to merge 5 commits into
developfrom
wip/kw/ag-grid-vue3-35
Open

Update to Ag Grid 35#14972
kazcw wants to merge 5 commits into
developfrom
wip/kw/ag-grid-vue3-35

Conversation

@kazcw

@kazcw kazcw commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Pull Request Description

Update to Ag Grid 35.

  • We no longer need our own AG Grid Vue wrapper
  • Better type information
  • Modular imports
    • Ag Grid has always been one of the largest bundles we ship; importing only the APIs we use reduces bundle size by 60%.

Fixes #14954.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@kazcw kazcw self-assigned this Apr 16, 2026
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 16, 2026
@kazcw
kazcw force-pushed the wip/kw/ag-grid-vue3-35 branch from ca9a407 to 4bec960 Compare April 16, 2026 13:55
@kazcw
kazcw force-pushed the wip/kw/ag-grid-vue3-35 branch from 4bec960 to 0f16c46 Compare April 16, 2026 14:00
@kazcw
kazcw marked this pull request as ready for review April 16, 2026 14:05

@vitvakatu vitvakatu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right-click menu is broken:
Develop:

Image

This branch (in top left corner, attached to root)

Image

Also “Export” action from right-click is missing, I guess it requires CsvExportModule and ExcelExportModule.

Besides, the font and default column widths seem different… I mean it is probably expected with the update? Had to mention it anyway.

Develop:

Image

This branch:

Image

@kazcw

kazcw commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author
  • Missing exports menu: Fixed
  • Font: Fixed
  • Column sizing: The effective difference was partly due to the font size change, but also AG Grid has changed how elements are sized. It is not possible to configure sizing exactly the way it was before, but the new sizing is supposed to be more logical. We can tune the --ag-spacing parameter if needed; the current value looks reasonable to me.

@kazcw
kazcw marked this pull request as draft April 16, 2026 15:26
@kazcw

kazcw commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Our use of AG Grid is affected by a bug in AG Grid since version 33, described here: ag-grid/ag-grid#12910; and tracked as AG-16857. It is still present in version 35.2.0, but they are planning to fix this "in the next release". The result of the bug is that multiple cells cannot be selected by click-and-drag in the Table visualization (uses of AG Grid outside the visualization shadow root are unaffected). This issue is caught by our "Copy/paste from table visualization" integration test. Since AG Grid updates since the last version without this bug (32) are useful to us, and this bug may not be fixed for some time (AG Grid updates seem to be typically every 1-2 months; the current version was released 1 month ago), I'm working on a workaround to fix multi-cell selection in current AG Grid until upstream fixes the root of the bug.

@jdunkerley jdunkerley added this to the 2026.1 Release milestone Apr 17, 2026
@kazcw
kazcw marked this pull request as ready for review April 17, 2026 16:33
@kazcw
kazcw requested a review from vitvakatu April 17, 2026 16:33
@vitvakatu

Copy link
Copy Markdown
Contributor

The right-click menu is still broken for me:
CleanShot 2026-04-24 at 13 44 40@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update AgGrid

3 participants