Update to Ag Grid 35 - #14972
Conversation
ca9a407 to
4bec960
Compare
4bec960 to
0f16c46
Compare
vitvakatu
left a comment
There was a problem hiding this comment.
Right-click menu is broken:
Develop:
This branch (in top left corner, attached to root)
Also “Export” action from right-click is missing, I guess it requires CsvExportModule and ExcelExportModule.
Besides, the font and default column widths seem different… I mean it is probably expected with the update? Had to mention it anyway.
Develop:
This branch:
|
|
Our use of AG Grid is affected by a bug in AG Grid since version 33, described here: ag-grid/ag-grid#12910; and tracked as AG-16857. It is still present in version 35.2.0, but they are planning to fix this "in the next release". The result of the bug is that multiple cells cannot be selected by click-and-drag in the Table visualization (uses of AG Grid outside the visualization shadow root are unaffected). This issue is caught by our "Copy/paste from table visualization" integration test. Since AG Grid updates since the last version without this bug (32) are useful to us, and this bug may not be fixed for some time (AG Grid updates seem to be typically every 1-2 months; the current version was released 1 month ago), I'm working on a workaround to fix multi-cell selection in current AG Grid until upstream fixes the root of the bug. |

Pull Request Description
Update to Ag Grid 35.
Fixes #14954.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.