Conversation
Signed-off-by: CrazyMax <[email protected]>
thaJeztah
reviewed
Aug 6, 2026
| - bake-dockerhub-single | ||
| permissions: | ||
| contents: read | ||
| id-token: write |
Member
There was a problem hiding this comment.
do we want the comment here as well (I think we did on other repositories?)
Member
Author
There was a problem hiding this comment.
this workflow is just for testing and not production so no need imo
thaJeztah
reviewed
Aug 6, 2026
| sbom: true | ||
| set: | | ||
| *.args.VERSION={{meta.version}} | ||
| target: hello |
Member
Author
There was a problem hiding this comment.
GitHub diff is bad here. It's a duplicate where we had both OIDC auth and PAT auth so I removed the PAT auth basically.
thaJeztah
reviewed
Aug 6, 2026
| - bake-ghcr-and-dockerhub | ||
| permissions: | ||
| contents: read | ||
| id-token: write |
thaJeztah
approved these changes
Aug 6, 2026
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM, left some minor question and comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.