test: cover service ps pretty output - #7160
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
Signed-off-by: Andrew Barnes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #201
- What I did
Added coverage for the default
docker service pstable output, correspondingto the remaining pretty-print item in #201.
- How I did it
The test drives the command with a fake service and representative task, uses
--no-resolve, and checks stable headings and identifying row values withoutdepending on volatile elapsed-time output.
AI assistance: OpenAI Codex helped draft the test. I reviewed the complete diff
and validation evidence and take responsibility for the contribution.
- How to verify it
Run the focused
TestServicePsPrettyPrinttest in./cli/command/service.gofmt -d cli/command/service/ps_test.goandgit diff --checkare clean.On this Windows checkout, the broader package run still has the existing
LF/CRLF golden-output failures in
TestServiceContextWrite,TestPrettyPrint,and
TestServiceListOrder; the new test passes.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)