Skip to content

fix: avoid dtype comparison for None report metadata - #448

Draft
tomatotomata wants to merge 1 commit into
data-apis:masterfrom
tomatotomata:codex/mlx-none-dtype-447
Draft

fix: avoid dtype comparison for None report metadata#448
tomatotomata wants to merge 1 commit into
data-apis:masterfrom
tomatotomata:codex/mlx-none-dtype-447

Conversation

@tomatotomata

Copy link
Copy Markdown

Summary

  • avoid comparing None with array-library dtype objects before looking them up in dtype_to_name
  • add a regression test using an MLX-like dtype whose equality operation rejects None

Closes #447

Validation

  • ARRAY_API_TESTS_MODULE=numpy PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest -q -p pytest_jsonreport.plugin meta_tests/test_reporting.py passed: 1 test
  • ARRAY_API_TESTS_MODULE=numpy PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest -q -p pytest_jsonreport.plugin meta_tests/test_utils.py passed: 30 tests
  • python -m compileall -q reporting.py meta_tests/test_reporting.py passed
  • git diff --check passed

The full suite was not run. The focused commands disable unrelated globally installed pytest plugins and load the repository's JSON-report plugin explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None dtype comparison not supported in MLX

1 participant