Skip to content

Don't allow adding of existing host to another zone, pod or cluster - #13182

Open
vishesh92 wants to merge 1 commit into
apache:4.20from
shapeblue:fix-add-host-diff-location
Open

Don't allow adding of existing host to another zone, pod or cluster#13182
vishesh92 wants to merge 1 commit into
apache:4.20from
shapeblue:fix-add-host-diff-location

Conversation

@vishesh92

@vishesh92 vishesh92 commented May 18, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes #13080

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.27%. Comparing base (549daae) to head (0115b87).

Files with missing lines Patch % Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java 75.00% 5 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #13182   +/-   ##
=========================================
  Coverage     16.26%   16.27%           
- Complexity    13434    13445   +11     
=========================================
  Files          5667     5667           
  Lines        500731   500767   +36     
  Branches      60803    60809    +6     
=========================================
+ Hits          81455    81475   +20     
- Misses       410172   410181    +9     
- Partials       9104     9111    +7
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.12% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr shwstppr mentioned this pull request May 18, 2026
Closed
14 tasks
@apache apache deleted a comment from blueorangutan May 18, 2026
@vishesh92
vishesh92 force-pushed the fix-add-host-diff-location branch from 2f64bcd to 6bf5881 Compare May 18, 2026 12:06
@apache apache deleted a comment from blueorangutan May 18, 2026
@vishesh92

vishesh92 commented May 18, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan package

@sureshanaparti
sureshanaparti requested a review from Copilot May 18, 2026 17:17
Copilot AI reviewed May 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vishesh92
vishesh92 requested a review from Copilot May 18, 2026 19:26
@vishesh92

vishesh92 commented May 18, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan package

Copilot AI reviewed May 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Comment thread server/src/main/java/com/cloud/resource/ResourceManagerImpl.java Outdated
Comment thread server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
Comment thread server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
Comment thread server/src/main/java/com/cloud/resource/ResourceManagerImpl.java Outdated
Comment thread server/src/test/java/com/cloud/resource/ResourceManagerImplTest.java
@vishesh92
vishesh92 marked this pull request as ready for review May 19, 2026 08:10
@vishesh92

vishesh92 commented May 20, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan package

@vishesh92 vishesh92 linked an issue May 20, 2026 that may be closed by this pull request
Don't allow adding an existing KVM host to another zone #13080
Open
@vishesh92

vishesh92 commented May 21, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan package

@winterhazel winterhazel added this to the 4.20.4 milestone May 22, 2026
@vishesh92

vishesh92 commented May 22, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan test

DaanHoogland
DaanHoogland approved these changes May 27, 2026
View reviewed changes

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

winterhazel
winterhazel reviewed Jun 1, 2026
View reviewed changes
Comment thread server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
Comment thread server/src/main/java/com/cloud/resource/ResourceManagerImpl.java Outdated
@vishesh92 vishesh92 mentioned this pull request Jun 16, 2026
Merged
potiuk added a commit to potiuk/cloudstack that referenced this pull request Jun 17, 2026
@potiuk
draft-THREAT-MODEL.md: fold in vishesh92's follow-up answers
dcf3cfe 
- Q15: sensitive-file ownership root:cloud, mode 0640
- Q24: same-IP host re-add updates existing record, gated by creds + key/certs
  (apache#13182); not an unauthenticated spoof path
- Q29: data-at-rest delegation to storage/hypervisor confirmed by vishesh92

Generated-by: Claude Opus 4.8
@harikrishna-patnala

harikrishna-patnala commented Jun 23, 2026

Copy link
Copy Markdown
Member

@vishesh92 can you please address the remaining code review comments.

@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@DaanHoogland
DaanHoogland force-pushed the fix-add-host-diff-location branch from 97e2f7b to 9228b5a Compare August 4, 2026 08:00
@blueorangutan

blueorangutan commented Aug 4, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18759

@vishesh92
vishesh92 force-pushed the fix-add-host-diff-location branch from 9228b5a to 0115b87 Compare August 5, 2026 07:10
@vishesh92

vishesh92 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

blueorangutan commented Aug 5, 2026

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Aug 5, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18772

@vishesh92

vishesh92 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

blueorangutan commented Aug 5, 2026

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winterhazel winterhazel winterhazel left review comments
Copilot code review Copilot Copilot left review comments
@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

@harikrishna-patnala harikrishna-patnala

Labels

status:needs-testing

Projects

None yet

Milestone

4.20.4

Development

Successfully merging this pull request may close these issues.

Don't allow adding an existing KVM host to another zone

6 participants

@vishesh92 @harikrishna-patnala @blueorangutan @DaanHoogland @winterhazel