fix(routes/partners.netlify): replace 'lucide-react' icons with phosphor - #1113
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Netlify partner page replaces Lucide icons with corresponding Phosphor icons across feature sections, badges, CTA links, pricing, testimonials, and FAQ controls. Page content and behavior remain unchanged. ChangesNetlify icon migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | d25fb83 | Commit Preview URL Branch Preview URL |
Aug 05 2026, 01:03 AM |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/routes/partners.netlify.tsx`:
- Line 312: Update the CheckIcon usage to replace strokeWidth={3} with
Phosphor’s weight="bold" prop, preserving the intended heavier check appearance.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a2892caa-bfdd-462b-a8f2-24c3cdcb5f28
📒 Files selected for processing (1)
src/routes/partners.netlify.tsx
partners.netlify.tsximports twelve icons fromlucide-react, but that package is not inpackage.json. Lint fails onmain:This is the only file in
src/that reaches forlucide-react; every other icon on the site comes from@phosphor-icons/react.Fix
Swapped all twelve for their phosphor equivalents.
partners.railway.tsx— the sibling partner page — already maps almost this exact set, so the pairings follow it:ArrowUpRightArrowUpRightIconCheckCheckIconDollarSignCurrencyDollarIconGitPullRequestGitPullRequestIconGlobeGlobeIconInfinityInfinityIconLineChartChartLineIconPlusPlusIconRocketRocketIconShieldCheckShieldCheckIconUndo2ArrowUUpLeftIconZapLightningIconZapis the one pairing railway does not already have;LightningIconis what the rest of the site uses for that concept (routes/index.tsx,landing/DbLanding.tsx).Names are used unaliased, matching the convention established in #1094 rather than railway's
X as Yaliases.Verified
pnpm exec oxlint --type-awarenow reports 0 errors across 916 files — it reported 1 before.tscis clean for this file.Left alone:
strokeWidth={3}on the check badge is inert for phosphor, butpartners.railway.tsxcarries the same leftover, so tidying it belongs in a pass over both.Summary by CodeRabbit