Add theme options for code editor - #853
Draft
SharonStrats wants to merge 1 commit into
Draft
Conversation
Prompt: add an option to change the theme inside the code editor using css and html from lit Co-authored-by: GPT-5.4 Mini <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is against another PR where I moved the code editor to solid-ui (not staging yet). @bourgeoa you mentioned not loving the dark theme so I thought I'd just have a quick go at seeing what our options were for allowing users to change it inside the editor so we don't have to store their preferences (since this would mean deciding on a predicate etc and may take longer to implement)
Here is how it looks, but we could easily change the look this is just a rough draft. I created this for discussion.
Note: the light theme can be changed as well there are many different extensions we could pick from, if we did do this and chose this one i'd put some sort of border around the code.