Add the code editor - #852
Open
SharonStrats wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a reusable CodeEditor utility (based on CodeMirror 6) and exposes it from the library’s public entrypoint so it can be used across panes instead of being tied to a single pane implementation.
Changes:
- Added a new
CodeEditorclass with initialization, content replacement, read-only toggling, language switching, and dirty-state tracking. - Exported the new module via
src/lib/code-editorand re-exported it fromsrc/index.ts. - Added CodeMirror-related runtime dependencies and a unit test covering basic initialization and operations.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/codeEditor.test.js | Adds unit tests and CodeMirror mocks for the new CodeEditor. |
| src/lib/code-editor/index.ts | Public barrel export for the code editor module. |
| src/lib/code-editor/CodeEditor.ts | Implements the reusable CodeMirror-backed CodeEditor class. |
| src/index.ts | Re-exports lib/code-editor from the package entrypoint. |
| package.json | Bumps package version and adds CodeMirror/theme dependencies. |
| package-lock.json | Locks newly added CodeMirror/theme dependency tree. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SharonStrats
force-pushed
the
move-editor
branch
from
August 5, 2026 22:33
13250b1 to
07b8841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the code editor from source pane so it can be used in other panes.