fix: Exposure events sent without a variant and duplicated within a flush interval - #233
Draft
khvn26 wants to merge 1 commit into
Draft
fix: Exposure events sent without a variant and duplicated within a flush interval#233khvn26 wants to merge 1 commit into
khvn26 wants to merge 1 commit into
Conversation
…lush interval Send the $flag_exposure event from get_experiment_flag only when the flag exists, is enabled and carries a variant, with the variant key as the event value; log the cause at debug level otherwise. Deduplicate equal exposure events buffered within one flush interval, keyed on feature name, identifier and value. beep boop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #232.
get_experiment_flag()now sends the exposure event only when the flag exists, is enabled and carries a variant, and the event value is always the variant key. Each skipped case logs its cause at debug level: feature not found, feature disabled, or no variant.The event processor now deduplicates equal exposure events buffered within one flush interval. Custom events are never deduplicated. Duplicates from a failed-flush requeue remain possible (fine because delivery is at-least-once).